This revision was automatically updated to reflect the committed changes.
Closed by commit rL327017: Fix std unique pointer pretty-printer for new stl
versions (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44015
Fil
alexandreyy added a comment.
Thanks, @labath @clayborg .
@labath Could you please commit this patch?
https://reviews.llvm.org/D44015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
alexandreyy updated this revision to Diff 137153.
alexandreyy added a comment.
Changed NULL pointer
https://reviews.llvm.org/D44015
Files:
source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
===
labath added a comment.
Pretty close, just a couple of style issues.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:62
if (!valobj_backend_sp)
-return false;
+return NULL;
nullptr.
Comment at: source/Plu
alexandreyy updated this revision to Diff 137022.
alexandreyy added a comment.
Fix std unique pointer not printing
https://reviews.llvm.org/D44015
Files:
source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:65-76
ValueObjectSP tuple_sp =
valobj_sp->GetChildMemberWithName(ConstString("_M_t"), true);
+
+ ValueObjectSP tuple_sp_child =
+ tuple_sp->GetChildMemberWithNa
alexandreyy created this revision.
alexandreyy added reviewers: labath, clayborg.
Std unique pointers were not being printed. The unique pointer layout was
changed in libstdc++ 6.0.23.
https://reviews.llvm.org/D44015
Files:
source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
Index
