labath added a comment.
Since the android part wasn't obviously NFC, I figured I should be the one to
do it. And since the pthread_cancel is not available on android, I've had to
add the #else clause as well, which should fix the unreachable warning as well.
So I guess you could say this got co
clayborg added a comment.
Yes we want to avoid ever using this function. It only leads to bad things
happening.
https://reviews.llvm.org/D44056
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
labath added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
xiaobai wrote:
> labath wrote:
> > xiaobai wrote:
> > > labath wrote:
> > > > xiaobai wrote:
> > > > > aprantl wrot
xiaobai added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
labath wrote:
> xiaobai wrote:
> > labath wrote:
> > > xiaobai wrote:
> > > > aprantl wrote:
> > > > > What about:
labath added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
xiaobai wrote:
> labath wrote:
> > xiaobai wrote:
> > > aprantl wrote:
> > > > What about:
> > > > ```
> > > > #ifd
xiaobai added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
labath wrote:
> xiaobai wrote:
> > aprantl wrote:
> > > What about:
> > > ```
> > > #ifdef __ANDROID__
> > > e
krytarowski added a comment.
`::pthread_cancel` is available for NetBSD as well.
https://reviews.llvm.org/D44056
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
xiaobai wrote:
> aprantl wrote:
> > What about:
> > ```
> > #ifdef __ANDROID__
> > error.SetErrorString("HostTh
xiaobai added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
aprantl wrote:
> What about:
> ```
> #ifdef __ANDROID__
> error.SetErrorString("HostThreadPosix::Cancel() not
aprantl added inline comments.
Comment at: source/Host/posix/HostThreadPosix.cpp:44
if (IsJoinable()) {
#ifndef __ANDROID__
#ifndef __FreeBSD__
What about:
```
#ifdef __ANDROID__
error.SetErrorString("HostThreadPosix::Cancel() not supported on Android");
kubamracek created this revision.
kubamracek added reviewers: davide, jasonmolenda, jingham, aprantl.
https://reviews.llvm.org/D44056
Files:
source/Host/posix/HostThreadPosix.cpp
Index: source/Host/posix/HostThreadPosix.cpp
===
-
11 matches
Mail list logo
