This revision was automatically updated to reflect the committed changes.
Closed by commit rL329374: [debugserver] Fix LC_BUILD_VERSION load command
handling. (authored by friss, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Comment at: packages/Python/lldbsuite/test/decorators.py:359
+output = subprocess.check_output(["xcodebuild", "-showsdks"],
friss added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorOSType.py:16-18
+sim_devices_str = subprocess.check_output(['xcrun', 'simctl', 'list', '-j',
+ 'devices'])
+
labath added a comment.
I thing the changes are fine. The only part that worries me is the in-class
initialization of the simulator variables. I think this will fail on non-apple
hosts.
Comment at:
friss created this revision.
friss added reviewers: jasonmolenda, labath.
In one of the 2 places the LC_BUILD_VERSION load command is handled, there
is a bug preventing us from actually handling them (the address where to
read the load command was not updated). This patch factors reading the
