This revision was automatically updated to reflect the committed changes.
Closed by commit rL332067: Retrieve the deployment target when retrieving an
object files triple. (authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D46669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aprantl updated this revision to Diff 146235.
aprantl added a comment.
Added a REQUIRES: darwin
https://reviews.llvm.org/D46669
Files:
lit/Modules/lc_version_min.yaml
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Index: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
aprantl updated this revision to Diff 146234.
aprantl added a comment.
Much smaller test thanks to Pavel's suggestion!
https://reviews.llvm.org/D46669
Files:
lit/Modules/lc_version_min.yaml
source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Index:
labath added a comment.
The test you copied this from predates `lldb-test` (and it tests some behavior
quirks which are not nicely expressible in text output). We should have nicer
ways of testing things like this now. It should be sufficient to add a print
line which displays the triple in
aprantl created this revision.
aprantl added a reviewer: jasonmolenda.
Herald added a subscriber: mgorny.
Getting the deployment target can be significant information when rebuilding
clang modules since availability information could depend on it. The unittest
is cargo-culted from the ELF unit
