[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rL332702: Make ObjectFileMachO work on non-darwin platforms (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46934 Files:

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

labath updated this revision to Diff 147341. labath added a comment. - Use #ifndef approach for handling the constants. https://reviews.llvm.org/D46934 Files: lit/Modules/lc_version_min.yaml source/Initialization/CMakeLists.txt source/Initialization/SystemInitializerCommon.cpp

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

aprantl added a comment. In https://reviews.llvm.org/D46934#1102867, @labath wrote: > In https://reviews.llvm.org/D46934#1101963, @aprantl wrote: > > > Does that mean we can now also remove the #ifdef __APPLE__ from the > > objectfile unit tests? > > > Which ones do you mean? I wasn't aware we

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

aprantl added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextDarwinConstants.h:18 + KERNEL_SUCCESS = 0, + KERNEL_INVALID_ARGUMENT = 4, +}; I think I would prefer #ifndef KERN_INVALID_ARGUMENT #define KERN_INVALID_ARGUMENT 4 #endif

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

labath updated this revision to Diff 147286. labath added a comment. This is the version with new symbolic constants. I put them in a new file, as I couldn't think of a better place for them. I didn't want to put them in a too generic place as I don't think we should encourage their use (we

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

labath added a comment. In https://reviews.llvm.org/D46934#1101963, @aprantl wrote: > Does that mean we can now also remove the #ifdef __APPLE__ from the > objectfile unit tests? Which ones do you mean? I wasn't aware we had any. The thing I know of, which would be interesting to enable is

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

aprantl added a comment. Does that mean we can now also remove the #ifdef __APPLE__ from the objectfile unit tests? https://reviews.llvm.org/D46934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

jasonmolenda accepted this revision. jasonmolenda added a comment. Thanks for untangling this Pavel, I hadn't noticed we weren't building this plugin for non-darwin systems. I'd agree with Adrian's comment that we should have a constants like LLDB_KERNEL_SUCCESS / LLDB_KERNEL_INVALID_ARGUMENT,

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

labath added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:1037 SetError(set, Write, -1); -return KERN_INVALID_ARGUMENT; +return -1; } aprantl wrote: > Could we keep this as a local constant? > perhaps

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

aprantl added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:1037 SetError(set, Write, -1); -return KERN_INVALID_ARGUMENT; +return -1; } Could we keep this as a local constant? perhaps with an #ifndef

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

labath created this revision. labath added reviewers: jasonmolenda, aprantl, clayborg. Herald added subscribers: kristof.beyls, mgorny. Herald added a reviewer: javed.absar. Before this patch we were unable to write cross-platform MachO tests because the parsing code did not compile on other