This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334205: [Platform] Accept arbitrary kext variants (authored
by JDevlieghere, committed by ).
Herald added a subscriber:
JDevlieghere added a comment.
In https://reviews.llvm.org/D47539#1117114, @jasonmolenda wrote:
> LGTM. If we added more knowledge specifically about kext bundle layouts, we
> could restrict which files we test to see if they are valid binaries - but
> we'd need to parse the Info.plist at the
jasonmolenda added a comment.
LGTM. If we added more knowledge specifically about kext bundle layouts, we
could restrict which files we test to see if they are valid binaries - but we'd
need to parse the Info.plist at the top (to get the CFBundleExecutable name,
and look for variations on
JDevlieghere updated this revision to Diff 149143.
JDevlieghere added a comment.
Don't use `EnumerateDirectory`
https://reviews.llvm.org/D47539
Files:
source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
Index:
JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, labath.
When loading kexts in `PlatformDarwinKernel`, we use the BundleID as the
filename to to create shared modules. In `GetSharedModule` we call
`ExamineKextForMatchingUUID` for any BundleID it finds that is a
