stella.stamenova added a comment.
In https://reviews.llvm.org/D51227#1212838, @aprantl wrote:
> Looks like we *really* need to figure out what the underlying bug is here,
> because there's not many platforms left after this patch.
> This patch is fine as a stopgap, but we can't have a feature
aprantl added a comment.
Looks like we *really* need to figure out what the underlying bug is here,
because there's not many platforms left after this patch.
This patch is fine as a stopgap, but we can't have a feature like this be in
the source code while being virtually untested, that's just
stella.stamenova marked an inline comment as done.
stella.stamenova added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50
@skipIfDarwin # Skip this test for now until we can figure out why tings
aren't working
stella.stamenova updated this revision to Diff 162444.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51227
Files:
packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
teemperor added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50
@skipIfDarwin # Skip this test for now until we can figure out why tings
aren't working on build bots
+@skipIfLinux # This test is timing out
stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, clayborg.
Herald added a subscriber: lldb-commits.
These are already skipped on Darwin because they cause build bot failures. Both
on the build bots as well as in our testing we have seen a number of these
tests
