[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
stella.stamenova added a comment. In https://reviews.llvm.org/D51227#1212838, @aprantl wrote: > Looks like we *really* need to figure out what the underlying bug is here, > because there's not many platforms left after this patch. > This patch is fine as a stopgap, but we can't have a feature like this be in > the source code while being virtually untested, that's just asking for > trouble. > > Greg, were you able to reproduce this? > Stella, do you have any logging available that could help Greg in tracking > down the root cause? It's fairly easy for me to reproduce, so if Greg has time to investigate, I can collect the logs he needs. Repository: rLLDB LLDB https://reviews.llvm.org/D51227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
aprantl added a comment. Looks like we *really* need to figure out what the underlying bug is here, because there's not many platforms left after this patch. This patch is fine as a stopgap, but we can't have a feature like this be in the source code while being virtually untested, that's just asking for trouble. Greg, were you able to reproduce this? Stella, do you have any logging available that could help Greg in tracking down the root cause? Repository: rLLDB LLDB https://reviews.llvm.org/D51227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
stella.stamenova marked an inline comment as done. stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test teemperor wrote: > "is well as" -> "as well as" (same for the other comments). Apparently I can't spell today. Thanks for catching this! Repository: rLLDB LLDB https://reviews.llvm.org/D51227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
stella.stamenova updated this revision to Diff 162444. Repository: rLLDB LLDB https://reviews.llvm.org/D51227 Files: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py Index: packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py @@ -76,6 +76,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_scopes_variables_setVariable_evaluate(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py @@ -19,6 +19,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_step(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py @@ -54,6 +54,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_stackTrace(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py @@ -21,6 +21,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_default(self): ''' @@ -40,6 +41,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_stopOnEntry(self): ''' @@ -61,6 +63,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_cwd(self): ''' @@ -89,6 +92,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_debuggerRoot(self): ''' @@ -118,6 +122,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_sourcePath(self): ''' @@ -145,6 +150,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux as well as Darwin @no_debug_info_test def test_disableSTDIO(self): ''' @@ -161,6 +167,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on
[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test "is well as" -> "as well as" (same for the other comments). Repository: rLLDB LLDB https://reviews.llvm.org/D51227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux
stella.stamenova created this revision. stella.stamenova added reviewers: asmith, clayborg. Herald added a subscriber: lldb-commits. These are already skipped on Darwin because they cause build bot failures. Both on the build bots as well as in our testing we have seen a number of these tests fail and hang. This change treats them the same way on Linux as they are treated on Darwin. Repository: rLLDB LLDB https://reviews.llvm.org/D51227 Files: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py Index: packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py @@ -76,6 +76,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_scopes_variables_setVariable_evaluate(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py @@ -19,6 +19,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_step(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py @@ -54,6 +54,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_stackTrace(self): ''' Index: packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py === --- packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py +++ packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py @@ -21,6 +21,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_default(self): ''' @@ -40,6 +41,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_stopOnEntry(self): ''' @@ -61,6 +63,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_cwd(self): ''' @@ -89,6 +92,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_debuggerRoot(self): ''' @@ -118,6 +122,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out and/or failing on Linux is well as Darwin @no_debug_info_test def test_sourcePath(self): ''' @@ -145,6 +150,7 @@ @skipIfWindows @skipIfDarwin # Skip this test for now until we can figure out why
