This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346920: Add setting to require hardware breakpoints.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54221?vs=174091=174136#toc
Repository:
rLLDB
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D54221
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere updated this revision to Diff 174091.
JDevlieghere added a comment.
Feedback Jim: move argument to the end of the list.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The lldb API's parameters are ordered input first than output. Pretty much all
the API's that take a Status as a parameter take it as the last parameter. So
it looks weird to
labath added a comment.
In https://reviews.llvm.org/D54221#1290638, @JDevlieghere wrote:
> In https://reviews.llvm.org/D54221#1290572, @labath wrote:
>
> > I recall something about linux on arm having a magic unmodifiable (even by
> > ptrace) page of memory, so this could be useful there too.
JDevlieghere updated this revision to Diff 173191.
JDevlieghere added a comment.
Update tests to use SB API.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/Target/Target.h
JDevlieghere updated this revision to Diff 173112.
JDevlieghere marked 18 inline comments as done.
JDevlieghere added a comment.
Feedback from Jim
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This is pretty good, but in all the places where some plan tries to find a
sub-plan to do its job, you are losing the text of the error when that job
fails. So the controlling
JDevlieghere updated this revision to Diff 173021.
JDevlieghere added a comment.
Remove `ValidatePlan` implementation for `ThreadPlanPython` as I believe it's
bogus.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/Breakpoint/Breakpoint.h
JDevlieghere updated this revision to Diff 173015.
JDevlieghere added a comment.
Fix bug for `thread until` and add test case.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/Target/Target.h
krytarowski added a comment.
On NetBSD one has to check PaX MPROTECT property of a traced process.
Something like:
bool IsMPROTECT(pid_t pid) {
#if defined(__NetBSD__)
int mib[3];
int paxflags;
size_t len = sizeof(paxflags);
mib[0] = CTL_PROC;
mib[1] = pid;
mib[2]
labath added a comment.
I recall something about linux on arm having a magic unmodifiable (even by
ptrace) page of memory, so this could be useful there too. However, it's not
clear to me how a user is going to figure out that he needs to enable this
setting. Would it make sense to
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, jasonmolenda.
JDevlieghere added a project: LLDB.
Herald added subscribers: teemperor, abidh.
When debugging read-only memory we cannot use software breakpoint. We already
have support for hardware breakpoints and users
13 matches
Mail list logo
