[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

JDevlieghere added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. Thanks @rupprecht! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL367241: [lldb] Qualify includes of Properties[Enum].inc files. NFC (authored by rupprecht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

rupprecht added a comment. Committed this for you as r367241, including a rebase past r367238 (which I really hope I didn't mess up -- `ninja check-lldb` passed, at least). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. This looks fine to me, and I think that the new file names fit pretty organically into the existing lldb conventions (as well as being mostly consistent with how llvm handles

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. In D65397#1604416 , @labath wrote: > I am not sure about the consistency argument (on the other CL), as it seems > to me that most/all llvm .inc files *which are produced by tblgen" are > included by via just their bare names.

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212167. sammccall added a comment. Fix one straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 Files: lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212166. sammccall added a comment. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Give the files distinct names instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

labath added a comment. I am not sure about the consistency argument (on the other CL), as it seems to me that most/all llvm .inc files *which are produced by tblgen" are included by via just their bare names. However, these files generally have unique names, which is usually achieved by just

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall created this revision. sammccall added reviewers: JDevlieghere, labath, chandlerc. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. labath added a comment. I am not sure about the consistency argument (on the other CL), as it seems to me that most/all llvm .inc