[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

This revision was automatically updated to reflect the committed changes. Closed by commit rG7644d8ba4dc4: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D70025?vs=228955&id=

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

krytarowski added a comment. In D70025#1758800 , @labath wrote: > LGTM, since this seems to be the best we can do given the current netbsd > behavior. > > However, I'd like to repeat what I said on the IRC, that I consider this > behavior of netbsd to be

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM, since this seems to be the best we can do given the current netbsd behavior. However, I'd like to repeat what I said on the IRC, that I consider th

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny updated this revision to Diff 228955. mgorny added a comment. Herald added a reviewer: jfb. Included fixed tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70025/new/ https://reviews.llvm.org/D70025 Files: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurr

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny updated this revision to Diff 228568. mgorny added a comment. Updated as noted in comments, particularly reuse `ClearWatchpointHit()` when setting new wp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70025/new/ https://reviews.llvm.org/D70025 Files: lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:334 thread->SetStoppedByTrace(); SetState(StateType::eStateStopped, true); krytarowski wrote: > I presume tha

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:899 + (dr7_value.GetAsUInt64() & bit_mask) != (rw_bits | size_bits)) { +// for watchpoints 0, 1, 2, or 3, respect

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:334 thread->SetStoppedByTrace(); SetState(StateType::eStateStopped, true); I presume that in this code path we land into a scenario that: 1. Tra

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Fix handling concurrent watchpoint events so that they are reported correctly in LLDB. If multiple watchpoints are hit concurrently, the NetBSD kernel reports them as series of SIGTRAPs with a thread specified, and the deb