[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process
This revision was automatically updated to reflect the committed changes. Closed by commit rG77cc246412ca: [lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI] (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 Files: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h @@ -47,6 +47,8 @@ Status Signal(int signo) override; + Status Interrupt() override; + Status Kill() override; Status GetMemoryRegionInfo(lldb::addr_t load_addr, Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp @@ -381,12 +381,7 @@ } Status NativeProcessNetBSD::Halt() { - Status error; - - if (kill(GetID(), SIGSTOP) != 0) -error.SetErrorToErrno(); - - return error; + return PtraceWrapper(PT_STOP, GetID()); } Status NativeProcessNetBSD::Detach() { @@ -411,6 +406,10 @@ return error; } +Status NativeProcessNetBSD::Interrupt() { + return PtraceWrapper(PT_STOP, GetID()); +} + Status NativeProcessNetBSD::Kill() { Log *log(ProcessPOSIXLog::GetLogIfAllCategoriesSet(POSIX_LOG_PROCESS)); LLDB_LOG(log, "pid {0}", GetID()); Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h @@ -47,6 +47,8 @@ Status Signal(int signo) override; + Status Interrupt() override; + Status Kill() override; Status GetMemoryRegionInfo(lldb::addr_t load_addr, Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp @@ -381,12 +381,7 @@ } Status NativeProcessNetBSD::Halt() { - Status error; - - if (kill(GetID(), SIGSTOP) != 0) -error.SetErrorToErrno(); - - return error; + return PtraceWrapper(PT_STOP, GetID()); } Status NativeProcessNetBSD::Detach() { @@ -411,6 +406,10 @@ return error; } +Status NativeProcessNetBSD::Interrupt() { + return PtraceWrapper(PT_STOP, GetID()); +} + Status NativeProcessNetBSD::Kill() { Log *log(ProcessPOSIXLog::GetLogIfAllCategoriesSet(POSIX_LOG_PROCESS)); LLDB_LOG(log, "pid {0}", GetID()); ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process
mgorny added a comment. Not that I know of. The main difference is how it behaves on a stopped process but I don't think we're ever issuing it on one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process
labath added a comment. Does this have any functional difference that would be useful to test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process
mgorny created this revision. mgorny added reviewers: labath, krytarowski. https://reviews.llvm.org/D70060 Files: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h @@ -47,6 +47,8 @@ Status Signal(int signo) override; + Status Interrupt() override; + Status Kill() override; Status GetMemoryRegionInfo(lldb::addr_t load_addr, Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp @@ -490,12 +490,7 @@ } Status NativeProcessNetBSD::Halt() { - Status error; - - if (kill(GetID(), SIGSTOP) != 0) -error.SetErrorToErrno(); - - return error; + return PtraceWrapper(PT_STOP, GetID()); } Status NativeProcessNetBSD::Detach() { @@ -520,6 +515,10 @@ return error; } +Status NativeProcessNetBSD::Interrupt() { + return PtraceWrapper(PT_STOP, GetID()); +} + Status NativeProcessNetBSD::Kill() { Log *log(ProcessPOSIXLog::GetLogIfAllCategoriesSet(POSIX_LOG_PROCESS)); LLDB_LOG(log, "pid {0}", GetID()); Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h @@ -47,6 +47,8 @@ Status Signal(int signo) override; + Status Interrupt() override; + Status Kill() override; Status GetMemoryRegionInfo(lldb::addr_t load_addr, Index: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp === --- lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp +++ lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp @@ -490,12 +490,7 @@ } Status NativeProcessNetBSD::Halt() { - Status error; - - if (kill(GetID(), SIGSTOP) != 0) -error.SetErrorToErrno(); - - return error; + return PtraceWrapper(PT_STOP, GetID()); } Status NativeProcessNetBSD::Detach() { @@ -520,6 +515,10 @@ return error; } +Status NativeProcessNetBSD::Interrupt() { + return PtraceWrapper(PT_STOP, GetID()); +} + Status NativeProcessNetBSD::Kill() { Log *log(ProcessPOSIXLog::GetLogIfAllCategoriesSet(POSIX_LOG_PROCESS)); LLDB_LOG(log, "pid {0}", GetID()); ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits