[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

2019-12-03 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2f1e7b3d01e1: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70979/new/ h

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

2019-12-03 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: lldb/include/lldb/Utility/ArchSpec.h:436 - void DumpTriple(Stream &s) const; + void DumpTriple(llvm::raw_ostream &s) const; Should we just make a static operator << function for this instead so we can use in form

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

2019-12-03 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70979/new/ https://reviews.llvm.org/D70979 ___ lldb-commit

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

2019-12-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70979 Files: lldb/include/lldb/Core/ModuleSpec.h lldb/include/lldb/Utility/ArchSpec.h