davide abandoned this revision.
davide added a comment.
Nevermind, I found a better way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70989/new/
https://reviews.llvm.org/D70989
___
lldb-commits
clayborg added a comment.
This seems like it will make a lot more work happen. Many C++ formatters are
regex based and are quite expensive to compare against type names. Seems
worthwhile to skip if the language doesn't match?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
davide added a comment.
Please don't merge this yet. I'm mostly trying to understand if this is dead
code or not.
@jingham , this is one of the places in generic code where we hardcode
knowledge about the languages. Needless to say, it causes conflicts downstream
and feels wrong anyway.
After
davide created this revision.
davide added reviewers: teemperor, friss, jingham.
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70989
Files:
lldb/include/lldb/DataFormatters/TypeCategory.h
lldb/source/DataFormatters/TypeCategory.cpp
Index:
