teemperor added a comment.
Huh, seems I uploaded to the wrong review
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72684/new/
https://reviews.llvm.org/D72684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
teemperor updated this revision to Diff 237953.
teemperor added a comment.
- Rebased to get rid of shady StringRef -> C-String conversion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72684/new/
https://reviews.llvm.org/D72684
Files:
teemperor added a comment.
Both TypeSystemClang and ClangTypeSystem works for me.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72684/new/
https://reviews.llvm.org/D72684
___
lldb-commits mailing list
labath added a comment.
`TypeSystemClang` would probably be more consistent with how other lldb classes
are named (`SymbolFileDWARF`, `ValueObjectChild`, etc.), but I don't have a big
problem with ClangTypeSystem either...
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
teemperor added a comment.
We are currently after a fresh rebranch downstream so now is a good time to
rename this without causing merge-conflict hell later on. It would be useful if
could get consensus if and to what we should rename this class soon-ish so that
I can make this move as
teemperor created this revision.
teemperor added reviewers: LLDB, aprantl, shafik, clayborg.
Herald added subscribers: lldb-commits, JDevlieghere, abidh.
Herald added a project: LLDB.
This commit renames ClangASTContext to ClangTypeSystem to better reflect what
this class is actually supposed to
