[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaed98e5b5d1: Convert CommandObjectCommands functions to return StringRefs (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. Can someone please land this patch for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 ___ lldb

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

labath added a comment. In D76569#1942271 , @jankratochvil wrote: > The ASan GCC report was valid ( > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) Ah, that is cute. :) Thanks for following this up. Now that the condition is gone (as it shou

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil accepted this revision. jankratochvil added a comment. The ASan GCC report was valid ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) but that was really just the first/previous version of the patch. I will try to check why clang ASan does not report it (and also GCC ASan

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1938577 , @labath wrote: > I wouldn't be too worried about asan as a StringRef provides the same > lifetime guarantees (== none) as a const char *. That's true but ASAN failed for me for the first patch. But that

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I wouldn't be too worried about asan as a StringRef provides the same lifetime guarantees (== none) as a const char *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 updated this revision to Diff 252125. shivammittal99 added a comment. Remove conditional and move raw_command_string line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 Files: lldb/source/

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

aprantl added a comment. In D76569#1936796 , @shivammittal99 wrote: > > run by hand ASAN-built LLDB for the code modified by this patch. > > How do I do that? This is my first PR to llvm, so I am not aware of the > tools. Please bear with me. FYI, afte

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1936796 , @shivammittal99 wrote: > How do I do that? This is my first PR to llvm, so I am not aware of the > tools. Please bear with me. No big deal, just compile it with `-DLLVM_USE_SANITIZER=Address` as you ha

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. > run by hand ASAN-built LLDB for the code modified by this patch. How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. I do not have the testsuite running with ASAN (it is also failing for me) but I expected to at least run by hand ASAN-built LLDB for the code modified by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7656

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. @jankratochvil When I use `LLVM_USE_SANITIZER=Address` and then run `ninja check-lldb` I get other errors: $ ninja check-lldb -j 1 [1/1981] Building DiagnosticDriverKinds.inc... FAILED: tools/clang/include/clang/Basic/DiagnosticDriverKinds.inc cd /home/sh

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. Have you run the build with address sanitizer? Comment at: lldb/source/Commands/CommandObjectCommands.cpp:530 OptionsWithRaw args_with_suffix(raw_command_line); -const char *remainder = args_with_suffix.GetRawPart().c_str(); +llvm::St

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. I don't know why is `clang-tidy` failing. I haven't changed the import or any other file than `CommandObjectCommands.cpp`. @jingham @aprantl Could you please help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76569 Files: lldb/source/Commands/CommandObjectCommands.cpp Index: lldb/source/Commands/CommandObjectCommands.cpp =