[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

This revision was automatically updated to reflect the committed changes. Closed by commit rG57be22fa1797: [LLDB] Fix parsing of IPv6 host:port inside brackets (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252622. emrekultursay added a comment. - Added comments to Android-specific test cases, as suggested by labath@. - Reformatted lines that exceeded 80 chars. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay added a comment. I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. You already mention that in the commit message, but it may be nice to also mention somewhere near the test case that these kinds of "URL"s can occur when and connecting to and

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

kwk added a comment. LGTM but I haven't tested it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252499. emrekultursay edited the summary of this revision. emrekultursay added a comment. Added unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 Files: lldb/source/Utility/UriParser.cpp

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

shafik added a reviewer: labath. shafik added a comment. We need tests it looks like `UriParserTest.cpp` is the right place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay created this revision. emrekultursay added a reviewer: LLDB. Herald added a project: LLDB. When using IPv6 host:port pairs, typically the host is put inside brackets, such as [2601:1234:...:0213]:, and the UriParser can handle this format. However, the Android infrastructure in