[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG56de738d18e1: [lldb-server] Reset stop reason of all threads when resuming (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Sure. Btw, at this point, I think one of you guys should get commit-after-aproval access to the repository, so you can handle these things yourselves. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel, could you possibly land this for us? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-07 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Jim, do you think this is good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/test/API/functionalities/thread/break_step_other/TestThreadBreakStepOther.py:21 +class ThreadBreakStepOtherTestCase(TestBase): +mydir = TestBase.compute_mydir(__file__) + jarin wrote: > labath wrote: > > You

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/test/API/functionalities/thread/break_step_other/TestThreadBreakStepOther.py:21 +class ThreadBreakStepOtherTestCase(TestBase): +mydir = TestBase.compute_mydir(__file__) + labath wrote: > You can add

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262087. jarin marked 2 inline comments as done. jarin added a comment. ... now also fixed the 'volatile'. It took only three patches to copy four lines of code by hand. Not bad, huh? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262082. jarin added a comment. ... and remove the extra braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262081. jarin marked an inline comment as done. jarin added a comment. Addressed reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files:

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D79308#2017377 , @jarin wrote: > Yeah, I considered something like that, but then I thought it would be better > if the "other" thread only runs

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-04 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 261805. jarin added a comment. Simplify the test based on the suggestion from labath@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files:

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-04 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D79308#2017348 , @labath wrote: > The test setup here seems unnecessarily complex. Wouldn't an inferior like > this work better? > > void thread1() { > pseudo_barrier_wait(g_barrier); // See other tests how this works. >

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The test setup here seems unnecessarily complex. Wouldn't an inferior like this work better? void thread1() { pseudo_barrier_wait(g_barrier); // See other tests how this works. g_foo = 0; // break_here } int main() { pseudo_barrier_init(g_barrier1, 2);

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: jingham. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes the stop reason reset logic similar to MacOS' debugserver, where exceptions are reset for all threads when resuming process for stepping or