JDevlieghere added inline comments.
Comment at: lldb/source/Host/common/Socket.cpp:286
host_str = host_str.substr(1, host_str.size() - 2);
-bool ok = false;
-port = StringConvert::ToUInt32(port_str.c_str(), UINT32_MAX, 10, );
+bool ok =
shafik added inline comments.
Comment at: lldb/source/Interpreter/OptionValueArray.cpp:209
for (i = 0; i < argc; ++i) {
-const size_t idx =
-StringConvert::ToSInt32(args.GetArgumentAtIndex(i), INT32_MAX);
-if (idx >= size) {
+size_t
teemperor marked an inline comment as done.
teemperor added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1508
// thread in big endian hex
-tid = StringConvert::ToUInt64(value.c_str(), LLDB_INVALID_THREAD_ID, 16);
-if (tid
teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: JDevlieghere, abidh.
teemperor edited the summary of this revision.
This replaces most uses of LLDB's own String to int/float conversion
implementation with
LLVM's to_integer. The only remaining code in
