[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

uweigand added a comment. In D82622#2122708 , @Higuoxing wrote: > In D82622#2122562 , @uweigand wrote: > > > This commit causes test case failures on s390x (unfortunately hidden as the > > build bot was already red

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

uweigand added a comment. This commit causes test case failures on s390x (unfortunately hidden as the build bot was already red due to an unrelated issue): http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624 http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624/steps/ninj

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe08ab542bd6: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Forgot to mark as accepted before, but one more comment to add. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515 -#CHECK: DWARF: -#CHECK:

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing updated this revision to Diff 273632. Higuoxing marked 2 inline comments as done. Higuoxing added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82622/new/ https://reviews.llvm.org/D82622 Files: lldb/test/AP

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing marked an inline comment as done. Higuoxing added a comment. Thanks for reviewing! Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515 -#CHECK: DWARF: -#CHECK: debug_info: -#CHECK: - Length: -#CHECK: TotalLength:

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

jhenderson added a comment. LGTM. Well done on catching the lldb failures - I don't even build lldb by default personally. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515 -#CHECK: DWARF: -#CHECK: debug_info: -#CHECK: - Length:

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing updated this revision to Diff 273584. Higuoxing added a comment. Prettify test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82622/new/ https://reviews.llvm.org/D82622 Files: lldb/test/API/functionalities/source-map/a.yaml lld

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, hiraditya, aprantl, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added