[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere added a comment. In D88840#2314883 , @labath wrote: > In D88840#2314860 , @JDevlieghere > wrote: > >> In D88840#2314594 , @labath wrote: >> >>> One way this

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

labath added a comment. In D88840#2314860 , @JDevlieghere wrote: > In D88840#2314594 , @labath wrote: > >> One way this could be simplified further is to ditch `-P` and pass down the >> appropriate value from

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere added a comment. In D88840#2314594 , @labath wrote: > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >> >>> About `-P`,

Re: [Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

> On Oct 6, 2020, at 8:40 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >>

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

labath added a comment. In D88840#2314587 , @rupprecht wrote: > In D88840#2313331 , @kastiglione > wrote: > >> About `-P`, the man page for `lldb` and the driver's `Options.td` say it: >> >>> Prints out the path

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht added a comment. In D88840#2313331 , @kastiglione wrote: > About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > >> Prints out the path to the lldb.py file for this version of lldb. > > Should it do just that? If so this

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

kastiglione added a comment. About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > Prints out the path to the lldb.py file for this version of lldb. Should it do just that? If so this can be simplified further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGf22496a9f4ca: [dotest] Simplify logic to find the Python path (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:550-551 +# If our lldb supports the -P option, use it to find the python path: +with open(os.devnull, 'w') as DEVNULL: +

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:550-551 +# If our lldb supports the -P option, use it to find the python path: +with

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere updated this revision to Diff 296239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88840/new/ https://reviews.llvm.org/D88840 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere updated this revision to Diff 296229. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88840/new/ https://reviews.llvm.org/D88840 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

JDevlieghere created this revision. JDevlieghere added reviewers: rupprecht, labath, mgorny, teemperor. JDevlieghere requested review of this revision. Simplify the logic of parsing the `lldb -P` output to find the python path. This removes the special handling for the LLDB.framework and instead