[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 318298. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/lua/lua-typemaps.swig Index:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2511222 , @JDevlieghere wrote: > I replied before I actually tried to understand what your'e trying to > achieve, and it's still not entirely clear to me. I think what you need is > something similar like

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

JDevlieghere added a comment. I replied before I actually tried to understand what your'e trying to achieve, and it's still not entirely clear to me. I think what you need is something similar like `python-typemaps.swig` which helps swig understand `char**` types and such. For context,

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? If overloaded with `const char

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? Hmmm, that's tricky. I will see if I can come up

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela updated this revision to Diff 317439. tammela added a comment. Removing spurious line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94937/new/ https://reviews.llvm.org/D94937 Files: lldb/bindings/interface/SBStructuredData.i

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch changes the GetStringValue method on the SBStructuredData class to return a `const char *`. This change allows the use of the method on the