[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

labath added a comment. In D95165#2515232 , @augusto2112 wrote: > @labath, you were absolutely correct! It was simply a matter of saving and > restoring the terminal struct on the `terminalHasColors` function in the > `Process.inc` file (I really

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. @labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the `terminalHasColors` function in the `Process.inc` file (I really should've tried that before). I'm currently recompiling and will re-run the tests

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

labath added a comment. Can you be more specific about what is the nature and cause of this breakage? Could it maybe be the fact that the `set_curterm(nullptr)` call (inside `terminalHasColors(fd)`) leaves terminfo with no "current" terminal, (whereas before the call it contained the "current"

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This issue was found on the Swift REPL. However, I tested @teemperor's C REPL patch (https://reviews.llvm.org/D87281) and the same problem shows up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux

augusto2112 created this revision. augusto2112 added reviewers: teemperor, aprantl, jingham, mib. Herald added a subscriber: krytarowski. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On some Linux distributions, after