[Lldb-commits] [lldb] [lldb-dap] Use css class tabulator-tick (PR #207608)

2026-07-05 Thread Ely Ronnen via lldb-commits 

https://github.com/eronnen updated 
https://github.com/llvm/llvm-project/pull/207608

>From 62bf8201b9201a4066fc819fc6f2588c09981133 Mon Sep 17 00:00:00 2001
From: Ely Ronnen 
Date: Sun, 5 Jul 2026 21:46:12 +0200
Subject: [PATCH] [lldb-dap] Use css class tabulator-tick

---
 lldb/tools/lldb-dap/extension/package.json| 4 ++--
 .../lldb-dap/extension/src/ui/symbols-webview-html.ts | 8 
 .../lldb-dap/extension/src/webview/symbols-table-view.ts  | 8 
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lldb/tools/lldb-dap/extension/package.json 
b/lldb/tools/lldb-dap/extension/package.json
index 4ddc98817203e..41e39093d5235 100644
--- a/lldb/tools/lldb-dap/extension/package.json
+++ b/lldb/tools/lldb-dap/extension/package.json
@@ -33,7 +33,7 @@
   "devDependencies": {
 "@types/mocha": "^10.0.10",
 "@types/node": "^18.19.41",
-"@types/tabulator-tables": "^6.2.10",
+"@types/tabulator-tables": "^6.3.4",
 "@types/vscode": "1.90.0",
 "@types/vscode-webview": "^1.57.5",
 "@vscode/debugprotocol": "^1.68.0",
@@ -46,7 +46,7 @@
 "prettier": "^3.4.2",
 "prettier-plugin-curly": "^0.3.1",
 "prettier-plugin-organize-imports": "^4.3.0",
-"tabulator-tables": "^6.3.1",
+"tabulator-tables": "^6.5.2",
 "typescript": "^5.7.3"
   },
   "activationEvents": [
diff --git a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts 
b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
index b3dc4e1613ec3..ed60c2577daa8 100644
--- a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
+++ b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
@@ -55,6 +55,14 @@ export function getSymbolsTableHTMLContent(
   .tabulator-cell {
 text-overflow: clip !important;
   }
+  
+  .tabulator .tabulator-cell .tabulator-tick {
+fill: var(--vscode-editor-foreground);
+  }
+
+  .tabulator .tabulator-cell .tabulator-cross {
+fill: var(--vscode-editor-foreground);
+  }
 
   #symbols-table {
 width: 100%;
diff --git a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts 
b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
index 588b2c1070e20..a7088815f7da8 100644
--- a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
+++ b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
@@ -1,11 +1,6 @@
 import type { CellComponent, ColumnDefinition } from "tabulator-tables";
 import type { SymbolType } from "..";
 
-/// SVG from 
https://github.com/olifolkerd/tabulator/blob/master/src/js/modules/Format/defaults/formatters/tickCross.js
-/// but with the default font color.
-/// hopefully in the future we can set the color as parameter: 
https://github.com/olifolkerd/tabulator/pull/4791
-const TICK_ELEMENT = ``;
-
 function getTabulatorHexaFormatter(
   padding: number,
 ): (cell: CellComponent) => string {
@@ -49,7 +44,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -61,7 +55,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -73,7 +66,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },

___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use css class tabulator-tick (PR #207608)

2026-07-05 Thread via lldb-commits 

llvmorg-github-actions[bot] wrote:




@llvm/pr-subscribers-lldb

Author: Ely Ronnen (eronnen)


Changes

Upgrading [tabulator](https://www.npmjs.com/package/tabulator-tables) and using 
configurable CSS class "tabulator-tick" in order to have a natural tick color, 
instead of hard-coding the SVG

---
Full diff: https://github.com/llvm/llvm-project/pull/207608.diff


3 Files Affected:

- (modified) lldb/tools/lldb-dap/extension/package.json (+2-2) 
- (modified) lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts (+9) 
- (modified) lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts 
(-8) 


``diff
diff --git a/lldb/tools/lldb-dap/extension/package.json 
b/lldb/tools/lldb-dap/extension/package.json
index 4ddc98817203e..41e39093d5235 100644
--- a/lldb/tools/lldb-dap/extension/package.json
+++ b/lldb/tools/lldb-dap/extension/package.json
@@ -33,7 +33,7 @@
   "devDependencies": {
 "@types/mocha": "^10.0.10",
 "@types/node": "^18.19.41",
-"@types/tabulator-tables": "^6.2.10",
+"@types/tabulator-tables": "^6.3.4",
 "@types/vscode": "1.90.0",
 "@types/vscode-webview": "^1.57.5",
 "@vscode/debugprotocol": "^1.68.0",
@@ -46,7 +46,7 @@
 "prettier": "^3.4.2",
 "prettier-plugin-curly": "^0.3.1",
 "prettier-plugin-organize-imports": "^4.3.0",
-"tabulator-tables": "^6.3.1",
+"tabulator-tables": "^6.5.2",
 "typescript": "^5.7.3"
   },
   "activationEvents": [
diff --git a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts 
b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
index b3dc4e1613ec3..c535045b1f9c5 100644
--- a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
+++ b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
@@ -54,6 +54,15 @@ export function getSymbolsTableHTMLContent(
 
   .tabulator-cell {
 text-overflow: clip !important;
+
+  }
+  
+  .tabulator .tabulator-cell .tabulator-tick {
+fill: var(--vscode-editor-foreground);
+  }
+
+  .tabulator .tabulator-cell .tabulator-cross {
+fill: var(--vscode-editor-foreground);
   }
 
   #symbols-table {
diff --git a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts 
b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
index 588b2c1070e20..a7088815f7da8 100644
--- a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
+++ b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
@@ -1,11 +1,6 @@
 import type { CellComponent, ColumnDefinition } from "tabulator-tables";
 import type { SymbolType } from "..";
 
-/// SVG from 
https://github.com/olifolkerd/tabulator/blob/master/src/js/modules/Format/defaults/formatters/tickCross.js
-/// but with the default font color.
-/// hopefully in the future we can set the color as parameter: 
https://github.com/olifolkerd/tabulator/pull/4791
-const TICK_ELEMENT = ``;
-
 function getTabulatorHexaFormatter(
   padding: number,
 ): (cell: CellComponent) => string {
@@ -49,7 +44,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -61,7 +55,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -73,7 +66,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },

``




https://github.com/llvm/llvm-project/pull/207608
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use css class tabulator-tick (PR #207608)

2026-07-05 Thread Ely Ronnen via lldb-commits 

https://github.com/eronnen created 
https://github.com/llvm/llvm-project/pull/207608

Upgrading [tabulator](https://www.npmjs.com/package/tabulator-tables) and using 
configurable CSS class "tabulator-tick" in order to have a natural tick color, 
instead of hard-coding the SVG

>From 5c03c1292396d3f64d5b16084e052fb54b360b68 Mon Sep 17 00:00:00 2001
From: Ely Ronnen 
Date: Sun, 5 Jul 2026 21:46:12 +0200
Subject: [PATCH] [lldb-dap] Use css class tabulator-tick

---
 lldb/tools/lldb-dap/extension/package.json   | 4 ++--
 .../lldb-dap/extension/src/ui/symbols-webview-html.ts| 9 +
 .../lldb-dap/extension/src/webview/symbols-table-view.ts | 8 
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/lldb/tools/lldb-dap/extension/package.json 
b/lldb/tools/lldb-dap/extension/package.json
index 4ddc98817203e..41e39093d5235 100644
--- a/lldb/tools/lldb-dap/extension/package.json
+++ b/lldb/tools/lldb-dap/extension/package.json
@@ -33,7 +33,7 @@
   "devDependencies": {
 "@types/mocha": "^10.0.10",
 "@types/node": "^18.19.41",
-"@types/tabulator-tables": "^6.2.10",
+"@types/tabulator-tables": "^6.3.4",
 "@types/vscode": "1.90.0",
 "@types/vscode-webview": "^1.57.5",
 "@vscode/debugprotocol": "^1.68.0",
@@ -46,7 +46,7 @@
 "prettier": "^3.4.2",
 "prettier-plugin-curly": "^0.3.1",
 "prettier-plugin-organize-imports": "^4.3.0",
-"tabulator-tables": "^6.3.1",
+"tabulator-tables": "^6.5.2",
 "typescript": "^5.7.3"
   },
   "activationEvents": [
diff --git a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts 
b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
index b3dc4e1613ec3..c535045b1f9c5 100644
--- a/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
+++ b/lldb/tools/lldb-dap/extension/src/ui/symbols-webview-html.ts
@@ -54,6 +54,15 @@ export function getSymbolsTableHTMLContent(
 
   .tabulator-cell {
 text-overflow: clip !important;
+
+  }
+  
+  .tabulator .tabulator-cell .tabulator-tick {
+fill: var(--vscode-editor-foreground);
+  }
+
+  .tabulator .tabulator-cell .tabulator-cross {
+fill: var(--vscode-editor-foreground);
   }
 
   #symbols-table {
diff --git a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts 
b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
index 588b2c1070e20..a7088815f7da8 100644
--- a/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
+++ b/lldb/tools/lldb-dap/extension/src/webview/symbols-table-view.ts
@@ -1,11 +1,6 @@
 import type { CellComponent, ColumnDefinition } from "tabulator-tables";
 import type { SymbolType } from "..";
 
-/// SVG from 
https://github.com/olifolkerd/tabulator/blob/master/src/js/modules/Format/defaults/formatters/tickCross.js
-/// but with the default font color.
-/// hopefully in the future we can set the color as parameter: 
https://github.com/olifolkerd/tabulator/pull/4791
-const TICK_ELEMENT = ``;
-
 function getTabulatorHexaFormatter(
   padding: number,
 ): (cell: CellComponent) => string {
@@ -49,7 +44,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -61,7 +55,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },
@@ -73,7 +66,6 @@ const SYMBOL_TABLE_COLUMNS: ColumnDefinition[] = [
 widthGrow: 0.8,
 formatter: "tickCross",
 formatterParams: {
-  tickElement: TICK_ELEMENT,
   crossElement: false,
 },
   },

___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits