Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r257670. https://reviews.llvm.org/D16149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-01-13 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Ops, sorry, didn't notice the tid_t type map was actually added back later on in the patch. My bad. I'm going to accept this for now, with the caveat that we'll need to work t

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-01-13 Thread Zachary Turner via lldb-commits
zturner added a comment. I just moved tid to the bottom because it was in the middle of the in, out, and typecheck versions of the char** typemap. So I wanted to group them all together. Anyway, yea this didn't seem too controversial to me but I figured I'd throw it up here for review in case

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-01-13 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Did you mean to delete the tid_t typemap as well? Assuming there truly are identical typemaps and these are just copies, and everything works just as well when they are removed, I have no objection http://reviews.llvm.org/D16149 __