Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Sagar Thakur via lldb-commits]

sagar closed this revision.
sagar added a comment.

Committed in revision 262011.


Repository:
  rL LLVM

http://reviews.llvm.org/D17131



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Nitesh Jain via lldb-commits]

nitesh.jain updated this revision to Diff 47776.
nitesh.jain added a comment.

Update the diff as per suggestion.


Repository:
  rL LLVM

http://reviews.llvm.org/D17131

Files:
  
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py

Index: 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
===
--- 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
+++ 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
@@ -17,6 +17,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting(self):
 """Test that lldb reliably catches the inferior asserting (command)."""
 self.build()
@@ -31,6 +32,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_disassemble(self):
 """Test that lldb reliably disassembles frames after asserting 
(command)."""
 self.build()
@@ -45,6 +47,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_expr(self):
 """Test that the lldb expression interpreter can read from the 
inferior after asserting (command)."""
 self.build()
@@ -52,6 +55,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_step(self):
 """Test that lldb functions correctly after stepping through a call to 
assert()."""
 self.build()


Index: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
===
--- packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
+++ packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
@@ -17,6 +17,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting(self):
 """Test that lldb reliably catches the inferior asserting (command)."""
 self.build()
@@ -31,6 +32,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_disassemble(self):
 """Test that lldb reliably disassembles frames after asserting (command)."""
 self.build()
@@ -45,6 +47,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_expr(self):
 """Test that the lldb expression interpreter can read from the inferior after asserting (command)."""
 self.build()
@@ -52,6 +55,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = '^mips')
 def test_inferior_asserting_step(self):
 """Test that lldb functions correctly after stepping through a call to assert()."""
 self.build()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Nitesh Jain via lldb-commits]

nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.

Thanks zturner.
Will update the diff as per suggestion.


Repository:
  rL LLVM

http://reviews.llvm.org/D17131



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Oleksiy Vyalov via lldb-commits]

ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rL LLVM

http://reviews.llvm.org/D17131



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Nitesh Jain via lldb-commits]

nitesh.jain updated this revision to Diff 47767.
nitesh.jain added a comment.

Updated as per suggestion.


Repository:
  rL LLVM

http://reviews.llvm.org/D17131

Files:
  
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py

Index: 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
===
--- 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
+++ 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
@@ -17,6 +17,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = 
re.compile('^mips'))
 def test_inferior_asserting(self):
 """Test that lldb reliably catches the inferior asserting (command)."""
 self.build()
@@ -31,6 +32,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = 
re.compile('^mips'))
 def test_inferior_asserting_disassemble(self):
 """Test that lldb reliably disassembles frames after asserting 
(command)."""
 self.build()
@@ -45,6 +47,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = 
re.compile('^mips'))
 def test_inferior_asserting_expr(self):
 """Test that the lldb expression interpreter can read from the 
inferior after asserting (command)."""
 self.build()
@@ -52,6 +55,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need 
to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = 
re.compile('^mips'))
 def test_inferior_asserting_step(self):
 """Test that lldb functions correctly after stepping through a call to 
assert()."""
 self.build()


Index: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
===
--- packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
+++ packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
@@ -17,6 +17,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = re.compile('^mips'))
 def test_inferior_asserting(self):
 """Test that lldb reliably catches the inferior asserting (command)."""
 self.build()
@@ -31,6 +32,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = re.compile('^mips'))
 def test_inferior_asserting_disassemble(self):
 """Test that lldb reliably disassembles frames after asserting (command)."""
 self.build()
@@ -45,6 +47,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = re.compile('^mips'))
 def test_inferior_asserting_expr(self):
 """Test that the lldb expression interpreter can read from the inferior after asserting (command)."""
 self.build()
@@ -52,6 +55,7 @@
 
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
 @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
+@expectedFailureAll(bugnumber="llvm.org/pr26592", triple = re.compile('^mips'))
 def test_inferior_asserting_step(self):
 """Test that lldb functions correctly after stepping through a call to assert()."""
 self.build()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Zachary Turner via lldb-commits]

Not going to block the change over this, but just as an fyi, you can
specify regexes without usign `re.compile`.  You can literally just pass a
string that is a regex, it will still work

On Thu, Feb 11, 2016 at 11:22 PM Nitesh Jain via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> nitesh.jain updated this revision to Diff 47767.
> nitesh.jain added a comment.
>
> Updated as per suggestion.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D17131
>
> Files:
>
> packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
>
> Index:
> packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
> ===
> ---
> packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
> +++
> packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
> @@ -17,6 +17,7 @@
>
>  @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793:
> need to implement support for detecting assertion / abort on Windows")
>  @expectedFailureLinux("llvm.org/pr25338", archs=['arm'])
> +@expectedFailureAll(bugnumber="llvm.org/pr26592", triple =
> re.compile('^mips'))
>  def test_inferior_asserting(self):
>  """Test that lldb reliably catches the inferior asserting
> (command)."""
>  self.build()
> @@ -31,6 +32,7 @@
>
>  @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793:
> need to implement support for detecting assertion / abort on Windows")
>  @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
> +@expectedFailureAll(bugnumber="llvm.org/pr26592", triple =
> re.compile('^mips'))
>  def test_inferior_asserting_disassemble(self):
>  """Test that lldb reliably disassembles frames after asserting
> (command)."""
>  self.build()
> @@ -45,6 +47,7 @@
>
>  @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793:
> need to implement support for detecting assertion / abort on Windows")
>  @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
> +@expectedFailureAll(bugnumber="llvm.org/pr26592", triple =
> re.compile('^mips'))
>  def test_inferior_asserting_expr(self):
>  """Test that the lldb expression interpreter can read from the
> inferior after asserting (command)."""
>  self.build()
> @@ -52,6 +55,7 @@
>
>  @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21793:
> need to implement support for detecting assertion / abort on Windows")
>  @expectedFailureLinux("llvm.org/pr25338", archs=['aarch64', 'arm'])
> +@expectedFailureAll(bugnumber="llvm.org/pr26592", triple =
> re.compile('^mips'))
>  def test_inferior_asserting_step(self):
>  """Test that lldb functions correctly after stepping through a
> call to assert()."""
>  self.build()
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

[Oleksiy Vyalov via lldb-commits]

ovyalov added inline comments.


Comment at: 
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22
@@ -20,1 +21,3 @@
+# Backtracing failed due to lack of prolog/epilog informations in assert 
function of libc.so.6
+@expectedFailureAll(triple = re.compile('^mips'))
 def test_inferior_asserting(self):

Could you file a new bug for this issue and put its link into the decorator?


Repository:
  rL LLVM

http://reviews.llvm.org/D17131



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits