Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r266392.
https://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Hahnfeld added a comment.
In http://reviews.llvm.org/D18848#407745, @zturner wrote:
> It should be fixed now, please sync and try again
Yes, thanks.
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
zturner added a comment.
It should be fixed now, please sync and try again
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
It should be fixed now, please sync and try again
On Thu, Apr 21, 2016 at 4:04 AM Jonas Hahnfeld
wrote:
> Hahnfeld added a comment.
>
> In http://reviews.llvm.org/D18848#406521, @labath wrote:
>
> > In http://reviews.llvm.org/D18848#406509, @zturner wrote:
> >
> > > I was under the impression the
Hahnfeld added a comment.
In http://reviews.llvm.org/D18848#406521, @labath wrote:
> In http://reviews.llvm.org/D18848#406509, @zturner wrote:
>
> > I was under the impression the make build was officially unsupported/dead?
>
>
> You can still cmake to generate makefiles (and it does that by defa
Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.
I think this one is breaking `make check-all` for me because it cannot find and
copy `test-pdb-types.exe`. Maybe this has to be checked in? `test-dwarf.exe`
and `test-pdb.exe` are in SVN as well...
http://reviews.llvm.org/D18848
Hmm, ok i will check it out later. I'm not sure why it's even trying to
copy an exe, should be only doing the pdb. Exe isn't even checked in
On Wed, Apr 20, 2016 at 8:08 AM Pavel Labath wrote:
> labath added a subscriber: labath.
> labath added a comment.
>
> In http://reviews.llvm.org/D18848#406
zturner added a comment.
Hmm, ok i will check it out later. I'm not sure why it's even trying to
copy an exe, should be only doing the pdb. Exe isn't even checked in
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llv
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D18848#406509, @zturner wrote:
> I was under the impression the make build was officially unsupported/dead?
You can still cmake to generate makefiles (and it does that by default).
In any case, this problem s
zturner added a comment.
I was under the impression the make build was officially unsupported/dead?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I was under the impression the make build was officially unsupported/dead?
On Wed, Apr 20, 2016 at 4:26 AM Jonas Hahnfeld
wrote:
> Hahnfeld added a subscriber: Hahnfeld.
> Hahnfeld added a comment.
>
> I think this one is breaking `make check-all` for me because it cannot
> find and copy `test-pd
vsk added a subscriber: vsk.
vsk added a comment.
Hi @zturner, this seems to have upset an lldb bot. Could you take a look
(https://llvm.org/bugs/show_bug.cgi?id=27362)?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@list
zturner added a comment.
I wrote a library in llvm which is independent of the Windows system dll
and is abstracted such that we can plug in a non Windows specific version
of a pdb parser once we understand the format well enough.
For now, if you're not on Windows this library will just return an
I wrote a library in llvm which is independent of the Windows system dll
and is abstracted such that we can plug in a non Windows specific version
of a pdb parser once we understand the format well enough.
For now, if you're not on Windows this library will just return an error if
you try to creat
clayborg added a comment.
Shouldn't the SymbolFilePDB be only enabled in windows since it is useless on
any other system since you are using the Windows system DLL to parse the info?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb
jingham added a subscriber: jingham.
jingham added a comment.
Done in r266407. It built for me after this.
Jim
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Done in r266407. It built for me after this.
Jim
> On Apr 14, 2016, at 6:34 PM, Zachary Turner via lldb-commits
> wrote:
>
> zturner added a comment.
>
> A new file was added, Greg or someone else at Apple may need to add it to
> the Xcode workspace
>
>
> http://reviews.llvm.org/D18848
>
zturner added a comment.
A new file was added, Greg or someone else at Apple may need to add it to
the Xcode workspace
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
A new file was added, Greg or someone else at Apple may need to add it to
the Xcode workspace
On Thu, Apr 14, 2016 at 6:26 PM Vedant Kumar wrote:
> vsk added a subscriber: vsk.
> vsk added a comment.
>
> Hi @zturner, this seems to have upset an lldb bot. Could you take a look (
> https://llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds good. Lets start with this and add on as needed.
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.
zturner added a comment.
That should be fine, but as long as I don't have to create a `TypeSP` for it
when someone calls `FindTypes`, which is the only thing I'm implementing here,
I think I should be ok. When I go to create `CXXRecordDecls` to complete class
types, or when I add support for s
clayborg added a comment.
So you will need to make up base types if you have any types that use them.
Like if a struct contains an "int", you will need to make an integer up and
feed it to your CXXRecordDecl. So you will probably need to add those functions
back. You will need them for:
- clas
zturner updated this revision to Diff 53780.
zturner added a comment.
Generated the wrong patch last time. This one should be good
http://reviews.llvm.org/D18848
Files:
include/lldb/Symbol/ClangASTContext.h
source/Plugins/SymbolFile/PDB/CMakeLists.txt
source/Plugins/SymbolFile/PDB/PDBAST
zturner updated this revision to Diff 53775.
zturner added a comment.
Changes from first patch:
1. Based on your other comment that it wasn't actually necessary to create a
`TypeSP` for builtin types, I went ahead and removed all the code that was
looking at bit and byte sizes. So all that stu
clayborg added a comment.
In http://reviews.llvm.org/D18848#397787, @zturner wrote:
> Thanks. One more question. Does SymbolFile::FindTypes need to be able to
> handle the case of a null type name (which I guess would indicate to find
> every type)?
No. It should handle the request without
Thanks. One more question. Does SymbolFile::FindTypes need to be able to
handle the case of a null type name (which I guess would indicate to find
every type)?
On Fri, Apr 8, 2016 at 3:24 PM Greg Clayton wrote:
> clayborg added a comment.
>
> In http://reviews.llvm.org/D18848#395933, @zturner
clayborg added a comment.
In http://reviews.llvm.org/D18848#395933, @zturner wrote:
> I mean for example if someone calls `FindTypes(..., "char", ...);`
>
> Should a `TypeSP` go into the map?
No you don't have to make one up if you don't have one. At least this is what
the DWARF parser does. T
zturner added a comment.
I mean for example if someone calls `FindTypes(..., "char", ...);
Should a `TypeSP` go into the map?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
zturner added a comment.
Greg, what should happen when you look up a builtin type like "char" or
"float"? Is there supposed to be a unique `TypeSP` for this somewhere, with a
unique uid?
http://reviews.llvm.org/D18848
___
lldb-commits mailing lis
zturner added a comment.
In http://reviews.llvm.org/D18848#394756, @clayborg wrote:
> > One oddity of PDB is that the debug info does not maintain enough
> > information to accurately reconstruct the DeclContext hierarchy. If you
> > have this:
>
> >
>
> > namespace Foo
>
> > {
>
> >
clayborg added a comment.
> One oddity of PDB is that the debug info does not maintain enough information
> to accurately reconstruct the DeclContext hierarchy. If you have this:
>
> namespace Foo
> {
> class Bar
> {
> class Baz
> {
> };
>
clayborg added a comment.
See inlined comments.
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:154-156
@@ +153,5 @@
+
+CompilerType clang_type =
+m_ast.CreateRecordType(tu_decl_ctx, access,
udt->getName().c_str(), TranslateUdtKind(udt_kind),
+
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:154-156
@@ +153,5 @@
+
+CompilerType clang_type =
+m_ast.CreateRecordType(tu_decl_ctx, access,
udt->getName().c_str(), TranslateUdtKind(udt_kind),
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few minor changes, but you are on the right track.
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:75-121
@@ +74,49 @@
+{
+switch (type.getBuilt
34 matches
Mail list logo
