sylvestre.ledru updated this revision to Diff 72758.
sylvestre.ledru added a comment.
Herald added subscribers: mgorny, beanz.
Updated by Pino!
https://reviews.llvm.org/D23977
Files:
cmake/LLDBDependencies.cmake
cmake/modules/LLDBConfig.cmake
scripts/Python/modules/CMakeLists.txt
emaste requested changes to this revision.
emaste added a reviewer: emaste.
emaste added a comment.
This revision now requires changes to proceed.
Two requested changes called out in comments above
https://reviews.llvm.org/D23977
___
lldb-commits
tfiala added a comment.
@sylvestre.ledru, I think this will be ready to go if you can convert that
check to a CMake built-in check. Maybe you can pass that along to Pino Toscano?
https://reviews.llvm.org/D23977
___
lldb-commits mailing list
tfiala added inline comments.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHES
emaste added a subscriber: emaste.
emaste added a comment.
- in the future can you please upload with context (e.g. git diff -U)
- I think the OS names in utilsOsType.py are kept sorted and the actual enum
values are not part of an ABI
https://reviews.llvm.org/D23977
krytarowski added a subscriber: krytarowski.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if
brucem added a subscriber: brucem.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME
