Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

That's strange. Are you synced to tip of trunk on clang, llvm, and lldb? Can you paste the output of "ninja -nv check-lldb" and the summary results of "ninja check-lldb"? On Wed, Oct 5, 2016 at 10:11 AM walter erquinigo wrote: > wallace added a comment. > > I've run the

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72597. wallace added a comment. minor nits https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72596. wallace added a comment. This time I'm calculating the address of the exports header correctly because it is an RVA address. https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Unfortunately this is still crashing for me in every single test. Can I ask how you are running the test suite? I am doing the following from a Windows 10 machine using Visual Studio 15: cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71995. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

I rebased it 2016-09-20 15:44 GMT-07:00 walter erquinigo : > wallace updated this revision to Diff 71995. > wallace added a comment. > > rebase > > > https://reviews.llvm.org/D24284 > > Files: > source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp >

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Just a heads up, I put the wrong differential revision in the commit message. Oh well. I submitted the other patch, not this one. Can you rebase this patch on top of the triple / os patch? It doesn't apply cleanly for me. On Tue, Sep 20, 2016 at 1:53 PM Zachary Turner

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

This revision was automatically updated to reflect the committed changes. Closed by commit rL282013: [PECOFF] Use the COFF subsystem field when determining the Triple. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D24284?vs=71855=71984#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I was using this patch as well https://reviews.llvm.org/D24530, which might be the reason why it fails on your side. I'll double check, but I'm pretty sure it's just that https://reviews.llvm.org/D24284 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. When I run ninja check-lldb with this patch, every single test crashes. It's crashing at ObjectFilePECOFF.cpp:583, which does this: const char *symbol_name_cstr =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71855. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71853. wallace added a comment. s/NULL/nullptr/ https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I'm obliged, your grace https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:89 @@ +88,3 @@ + if (!data_sp || !ObjectFilePECOFF::MagicBytesMatch(data_sp)) { +return NULL; + }

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. ping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71409. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71407. wallace added a comment. fix pointers https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:88 @@ +87,3 @@ + if (data_sp && ObjectFilePECOFF::MagicBytesMatch(data_sp)) { +std::auto_ptr objfile_ap( +new ObjectFilePECOFF(module_sp, data_sp, process_sp,

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71265. wallace updated the summary for this revision. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index:

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Right, I'm just wondering if when you run `ninja check-lldb` before and after this patch, do the results differ at all? Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mailing list