labath added a comment.
In https://reviews.llvm.org/D24610#554587, @omjavaid wrote:
> Give this approach a rethink I dont see a lot of problems with this final
> implementation unless it fails on other architectures.
> We are already hacking our way to have these byte selection watchpoints
> w
omjavaid updated this revision to Diff 72723.
omjavaid added a comment.
Give this approach a rethink I dont see a lot of problems with this final
implementation unless it fails on other architectures.
We are already hacking our way to have these byte selection watchpoints working
in existing cod
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D24610#553331, @omjavaid wrote:
> This is a new version of what seems to me fully implementing functionality we
> intend to have here.
>
> On a second tho
omjavaid updated this revision to Diff 72589.
omjavaid added a comment.
This is a new version of what seems to me fully implementing functionality we
intend to have here.
On a second thought nuking ClearHardwareWatchpoint function seems to be the
wrong approach here. I spent some time taking di
labath accepted this revision.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:513-521
@@ -513,1 +512,11 @@
+
+ // Find out how many bytes we need to watch after 4-byte alignment boundary.
+ uint8_t watch_size = (addr & 0x03) + size;
+
+ // We canno
omjavaid added a comment.
Answers to comments. I will upload a updated patch after corrections and
updates.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23
@@ +22,3 @@
+{
+printf("About to write byteArray[%d] .
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23
@@ +22,3 @@
+{
+printf("About to write byteArray[%d] ...\n", i); // About to write
byteArray
+
zturner wrote:
> What'
zturner added a subscriber: zturner.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23
@@ +22,3 @@
+{
+printf("About to write byteArray[%d] ...\n", i); // About to write
byteArray
+
What's up with
omjavaid updated this revision to Diff 71633.
omjavaid added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I have added a new test case that tests suggested scnario without changing any
previous test cases.
Also I have made sure we re validate all watchpoint installed on
omjavaid added a comment.
comments inline.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:43
@@ -42,2 +42,3 @@
"""Test to selectively watch different bytes in a 8-byte array."""
-self.run_watchpoint_
clayborg requested changes to this revision.
clayborg added a comment.
Great fix. Just fix the testing so that it isn't ARM specific. There shouldn't
be any:
if self.getArchitecture() in ['arm']:
do arm stuff
else:
do non arm stuff
Also we will need to be able to test the set watch
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have some doubts about the validity of this patch. We should make sure those
are cleared before putting this in.
Comment at:
packages/Python/lldbsuite/test/funct
12 matches
Mail list logo