Re: [Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

[Michał Górny via lldb-commits]

Dnia 5 sierpnia 2017 19:33:57 CEST, Zachary Turner  
napisał(a):
>Does this evaluate to nothing if curses is not present?

I will test to confirm in a minute but it should since the find_package call 
responsible for defining it is conditional to the disable var. 

However, it may evaluate to a non-null value if a parent project uses curses. 
Maybe I should make it explicitly respect LLDB_DISABLE_NCURSES then?

>On Sat, Aug 5, 2017 at 9:15 AM Michał Górny via Phabricator <
>revi...@reviews.llvm.org> wrote:
>
>> mgorny updated this revision to Diff 109879.
>> mgorny added a comment.
>>
>> Forgive my poor eyesight, obviously this could go into existing
>LINK_LIBS
>> ;-).
>>
>>
>> https://reviews.llvm.org/D36358
>>
>> Files:
>>   source/Core/CMakeLists.txt
>>
>>
>> Index: source/Core/CMakeLists.txt
>> ===
>> --- source/Core/CMakeLists.txt
>> +++ source/Core/CMakeLists.txt
>> @@ -62,6 +62,7 @@
>>  lldbPluginCPlusPlusLanguage
>>  lldbPluginObjCLanguage
>>  lldbPluginObjectFileJIT
>> +${CURSES_LIBRARIES}
>>
>>LINK_COMPONENTS
>>  BinaryFormat
>>
>>
>>


-- 
Best regards,
Michał Górny (by phone)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

[Zachary Turner via lldb-commits]

Does this evaluate to nothing if curses is not present?
On Sat, Aug 5, 2017 at 9:15 AM Michał Górny via Phabricator <
revi...@reviews.llvm.org> wrote:

> mgorny updated this revision to Diff 109879.
> mgorny added a comment.
>
> Forgive my poor eyesight, obviously this could go into existing LINK_LIBS
> ;-).
>
>
> https://reviews.llvm.org/D36358
>
> Files:
>   source/Core/CMakeLists.txt
>
>
> Index: source/Core/CMakeLists.txt
> ===
> --- source/Core/CMakeLists.txt
> +++ source/Core/CMakeLists.txt
> @@ -62,6 +62,7 @@
>  lldbPluginCPlusPlusLanguage
>  lldbPluginObjCLanguage
>  lldbPluginObjectFileJIT
> +${CURSES_LIBRARIES}
>
>LINK_COMPONENTS
>  BinaryFormat
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits