Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

That seems reasonable. Seems Aaron ran into this not because he was trying to do a regex search, but because he *wasnt* trying to do a regex search. So if he doesn’t have immediate need for a regex search, and if it’s not tested anyway, removing it seems fine On Wed, Dec 20, 2017 at 10:49 AM Greg

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

ok, good starting point then. We can submit another patch to add the find types by regex functionality. Greg > On Dec 18, 2017, at 9:54 AM, Zachary Turner wrote: > > I agree that's better long term, but this code was already there, and the > patch makes things strictly

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

I agree that's better long term, but this code was already there, and the patch makes things strictly better than before (literally just fixes a crash in existing code). So I think we can agree that this should be fixed, but as it's a bigger change I don't think it should hold up fixing a crash.

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

Can we try using lldb_private::RegularExpression for everything? (Long term, adding a new base class method seems like a better approach, but at least this quick fix is an immediate fix and should be strictly better than crashing) On Wed, Dec 13, 2017 at 10:27 AM Aaron Smith via Phabricator <

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

Please do add this as that is the best solution. If no other plug-ins currently support it, it is fine to just stub out the virtual function in SymbolFile::FindTypesByRegex(...) to return Error("unsupported") and we can implement it in the regex search later for DWARF and other plug-ins. Greg

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

SymbolFile does not have a method for searching by regex. There is a FindFunctions and FindGlobalVariables that allows searching by regex, but not one for types. That said, one could be added to the base class, yes. That does seem like a better long term solution. On Mon, Dec 11, 2017 at 1:37