Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-19 Thread Jim Ingham via lldb-commits
> On Jan 19, 2021, at 3:34 PM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: >> >> >> >>> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: >>> >>> On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > On Jan 17, 2021, at 10:47 AM,

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-19 Thread David Blaikie via lldb-commits
On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: > > > > > On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > >> > >> > >> > >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > >>> > >>> On Fri, Jan 15, 2021 at 6:22 PM Jim

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-19 Thread Jim Ingham via lldb-commits
> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: >> >> >> >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: >>> >>> On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: If you set a breakpoint on source lines with

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-19 Thread David Blaikie via lldb-commits
On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > > > > > On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: > >> > >> If you set a breakpoint on source lines with no line table entries, lldb > >> slides the actual match forward to

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-19 Thread Jim Ingham via lldb-commits
> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: >> >> If you set a breakpoint on source lines with no line table entries, lldb >> slides the actual match forward to the nearest line table entry to the given >> line number. That's

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-17 Thread David Blaikie via lldb-commits
On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: > > If you set a breakpoint on source lines with no line table entries, lldb > slides the actual match forward to the nearest line table entry to the given > line number. That's necessary for instance because if you lay out your > function

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-15 Thread Jim Ingham via lldb-commits
If you set a breakpoint on source lines with no line table entries, lldb slides the actual match forward to the nearest line table entry to the given line number. That's necessary for instance because if you lay out your function definitions over multiple lines they won't all get line table

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

2021-01-15 Thread David Blaikie via lldb-commits
"But because their source lines are outside the function source range" Not sure I understand that - the DWARF doesn't describe a function source range, right? Only the line a function starts on. And a function can have code from source lines in many files/offsets that are unrelated to the