Re: [Lldb-commits] [lldb] r281717 - [RenderScript] Support tracking and dumping reduction kernels

2016-09-21 Thread Luke Drummond via lldb-commits
Hi Zachary Thanks for the review. My comments are inline (I've cut down some of the diff context for brevity) On 16/09/16 15:57, Zachary Turner wrote: [snip] -#define MAXLINESTR_(x) "%" STRINGIFY(x) "s" -#define MAXLINESTR MAXLINESTR_(MAXLINE) +bool

Re: [Lldb-commits] [lldb] r281717 - [RenderScript] Support tracking and dumping reduction kernels

2016-09-16 Thread Zachary Turner via lldb-commits
On Fri, Sep 16, 2016 at 4:36 AM Luke Drummond via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: ldrumm > Date: Fri Sep 16 06:28:12 2016 > New Revision: 281717 > > URL: http://llvm.org/viewvc/llvm-project?rev=281717=rev > Log: > [RenderScript] Support tracking and dumping reduction