Re: [Lldb-commits] [lldb] r282196 - [CMake] Fixing a small hack in add_lldb_library

2016-09-23 Thread Zachary Turner via lldb-commits
BTW, a TON of unnecessary stuff currently depends on the clang tablegen targets, due to the way the libraries are not well layered. So you can be trying to build CommandObjectMemory.cpp, and all of a sudden it has to build the clang tablegen targets. Very frustrating for incremental development.

Re: [Lldb-commits] [lldb] r282196 - [CMake] Fixing a small hack in add_lldb_library

2016-09-22 Thread Chris Bieneman via lldb-commits
Also of note. This implementation is “standalone” safe. If LLDB is being built without clang (against a pre-installed clang) CLANG_TABLEGEN_TARGETS will not be set, so no dependency will be setup. That same concern came up in a similar patch I submitted to Swift. -Chris > On Sep 22, 2016, at 2

Re: [Lldb-commits] [lldb] r282196 - [CMake] Fixing a small hack in add_lldb_library

2016-09-22 Thread Zachary Turner via lldb-commits
Ok, cool! On Thu, Sep 22, 2016 at 2:23 PM Chris Bieneman wrote: > Calls to add_dependencies don’t setup linkage, they just setup build > order, so changing this has no impact on what is linked or how. > > -Chris > > On Sep 22, 2016, at 2:21 PM, Zachary Turner wrote: > > At the end of the day th

Re: [Lldb-commits] [lldb] r282196 - [CMake] Fixing a small hack in add_lldb_library

2016-09-22 Thread Chris Bieneman via lldb-commits
Calls to add_dependencies don’t setup linkage, they just setup build order, so changing this has no impact on what is linked or how. -Chris > On Sep 22, 2016, at 2:21 PM, Zachary Turner wrote: > > At the end of the day though, lldb DOES need to link against libclang. Is it > still doing this

Re: [Lldb-commits] [lldb] r282196 - [CMake] Fixing a small hack in add_lldb_library

2016-09-22 Thread Zachary Turner via lldb-commits
At the end of the day though, lldb DOES need to link against libclang. Is it still doing this? On Thu, Sep 22, 2016 at 2:17 PM Chris Bieneman via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Thu Sep 22 16:08:27 2016 > New Revision: 282196 > > URL: http://llvm.o