Re: [lldb-dev] FileSpec changes fallout and questions

2015-03-11 Thread jingham
> On Mar 11, 2015, at 2:50 PM, Zachary Turner wrote: > > I don't think that's correct. I think directory should be tmp and filename > should be null in that case. Yes, I agree creating a "." filename is the wrong behavior. That seems very weird. Jim > > It's interesting that this happen

Re: [lldb-dev] FileSpec changes fallout and questions

2015-03-11 Thread Zachary Turner
I don't think that's correct. I think directory should be tmp and filename should be null in that case. It's interesting that this happens when resolve == false, I would have thought most differences to arise when resolve == true. It's too bad we didn't have test/functionalities/paths back then.

[lldb-dev] FileSpec changes fallout and questions

2015-03-11 Thread Greg Clayton
FileSpec was changed a while back and currently if we make call like: FileSpec tmp("/tmp", false); will result in a m_filename that contains "." and a m_directory that contains "/tmp". Is this expected? If so we should to change: void FileSpec::AppendPathComponent (const char *new_path); to