Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread Zachary Turner
Great to hear! I will make this change to the style guide in the coming days if nobody objects further. In the meantime, I would love for you guys (and anyone else for that matter) to try out clang-format. It would be great to work out any kinks in the existing rules file. For cases where there

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread Kate Stone
> On Feb 9, 2015, at 12:45 PM, Zachary Turner wrote: > > I was trying to give you the benefit of the doubt :) TBH I'd be even happier > if we just use the LLVM rule consistently. But it's often easier for people > to do this slowly. From your original response though it sounds like you > mi

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread Zachary Turner
I was trying to give you the benefit of the doubt :) TBH I'd be even happier if we just use the LLVM rule consistently. But it's often easier for people to do this slowly. From your original response though it sounds like you might be fine just removing this rule and going with the LLVM style.

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread jingham
> On Feb 9, 2015, at 11:59 AM, Zachary Turner wrote: > > > > On Mon Feb 09 2015 at 11:56:44 AM wrote: > > I actually do think that having the space between the complex visual noise of > the argument list and the function name makes it easier to detect functions > when scanning code, which

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread jingham
> On Feb 9, 2015, at 10:53 AM, Zachary Turner wrote: > > A while back I asked about the possibility of bringing our style guide closer > to LLVM's. To that end, I made a clang-format configuration file for LLDB > and included it at the base of LLDB's repo. At the time I didn't know this, >

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread Zachary Turner
On Mon Feb 09 2015 at 11:56:44 AM wrote: > > I actually do think that having the space between the complex visual noise > of the argument list and the function name makes it easier to detect > functions when scanning code, which was why we did it this way to start. > That and from years of workin

Re: [lldb-dev] Style guide and clang-format.

2015-02-09 Thread Zachary Turner
one thing I forgot to add. The reason I'm bringing this up now is because I've seen more activity in LLDB over the past 2 months or so. Off the top of my head, we have people actively supporting Linux, Android, FreeBSD, Apple, Hexagon, multiple platforms with lldb-mi. I've also started to see mo

[lldb-dev] Style guide and clang-format.

2015-02-09 Thread Zachary Turner
A while back I asked about the possibility of bringing our style guide closer to LLVM's. To that end, I made a clang-format configuration file for LLDB and included it at the base of LLDB's repo. At the time I didn't know this, and I had my own hacked up solution, but it turns out it's very easy