Zachary,
your patch looks fine, except for one tiny point: could you leave the
CleanMakefile method in there and just have it do nothing? It was quite
annoying to find out what the right place to invoke that was, and I’m thinking
I might want to add an environment variable later that triggers
I put up a patch to lldb-commits. It's pretty trivial, but please take a
look anyway.
On Mon Dec 15 2014 at 10:41:06 AM Sean Callanan wrote:
> I like your idea: have Python generate a Makefile if one is not present
> and not delete the Makefile after the run. We just have to remember not to
>
I like your idea: have Python generate a Makefile if one is not present and not
delete the Makefile after the run. We just have to remember not to check
inline test cases’ Makefiles into the repository.
This way you can have your own Makefiles to build things – and in fact Python
will happily
Another possibility is dont' check in anything called Makefile, but instead
call the file something else. Like perhaps Makefile.test. You can still
easily cd into the directory and test this with make -f. This also
requires no code change, and there's some value in not making any code more
compl
I would like to see "Makefile" files for each test and avoid the "python will
magically do this for me" stuff. I had an inline test that was failing and
wanted to test what it was doing to figure out what was wrong and I added a
Makefile to the directory.
I vote to make each directory contain
Agreed, but that's a difficult problem to solve given the current
architecture of the test suite. In my ideal world, we would just build all
the test executables at the same time we build lldb, and that would even
speed up the test suite, but i think we're a ways away from that.
On Fri, Dec 12, 201
On 12/12/14 4:35 PM, Zachary Turner wrote:
lldb inline tests seem to generate their own Makefile and then clean it up
after they're done. lldb\test\lang\objc\objc-runtime-ivars seems to have a
Makefile checked into the repo. So when I run the test suite, it deletes
this repo and creates an an
Zach,
I think what would be idea is to have some way to tell the python file for a
given test to build the binary for that test.
In keeping with the minimalist philosophy for inline tests, it would be nice if
this didn’t require any modification (or required only very minimal
modification) to t
