Re: [lldb-dev] Patch for ValueObjectPrinter::PrintChildrenIfNeeded

Hi Nat!, The best way to do this is to go to http://reviews.llvm.org . Under Differential, click Create Diff, then paste in the raw diff for your patch. We like to see a full context diff, so reviewers can easily see the full file. More info on how to submit a patch here:

Re: [lldb-dev] RFC: Moving debug info parsing out of process

> On Mar 6, 2019, at 9:43 AM, Zachary Turner wrote: > > > On Mon, Mar 4, 2019 at 10:32 AM Zachary Turner > wrote: > On Sat, Mar 2, 2019 at 2:56 PM Adrian Prantl > wrote: >> It becomes testable as an independent component, because you can

Re: [lldb-dev] RFC: Moving debug info parsing out of process

On Mon, Mar 4, 2019 at 10:32 AM Zachary Turner wrote: > On Sat, Mar 2, 2019 at 2:56 PM Adrian Prantl wrote: > >> >>- It becomes testable as an independent component, because you can >>just send requests to it and dump the results and see if they make sense. >>Currently there is

[lldb-dev] March LLVM bay-area social is this Thursday!

We'll be at Tied House as usual, starting on Thursday the 7th at 7pm! If you can, help us plan and RSVP here: https://www.meetup.com/LLVM-Bay-Area-Social/events/kncsjlyzfbkb/ See everyone there! ___ lldb-dev mailing list lldb-dev@lists.llvm.org

Re: [lldb-dev] new tool (core2yaml) + a new top-level library (Formats)

Well, all of the actual yamlization code in obj2yaml and yaml2obj is library-ized, so you could always add the real code there, then have core2yaml just link against it On Wed, Mar 6, 2019 at 5:11 AM Pavel Labath wrote: > On 05/03/2019 22:52, Zachary Turner wrote: > > > > > > On Tue, Mar 5, 2019

[lldb-dev] Patch for ValueObjectPrinter::PrintChildrenIfNeeded

I couldn't figure out how to post a patch to reviews.llvm.org, so here it is per email, with the hope that someone adopts it :) Basically it's just moving the `bool print_oneline` out of the execution path, if no children are printed, since this value is then never used. This may not seem

Re: [lldb-dev] new tool (core2yaml) + a new top-level library (Formats)

On 05/03/2019 22:52, Zachary Turner wrote: On Tue, Mar 5, 2019 at 1:47 PM Jonas Devlieghere via lldb-dev mailto:lldb-dev@lists.llvm.org>> wrote: I don't know much about the minidump format or code, but it sounds reasonable for me to have support for it in yaml2obj, which would be