Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-02-01 Thread Pavel Labath via lldb-dev
On 30 January 2016 at 00:13, William Dillon wrote: > In a very real sense, no information is lost here. That is exactly the reason why it looks very hackish. :) It looks to me like you are trying to work around some other bug, probably in the code that consumes the triple. Could you point me to

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-29 Thread William Dillon via lldb-dev
Hi Omair, In a very real sense, no information is lost here. The addition of the ‘l’ only indicates that the system is little endian. When the triple is created, the flag setting little endian is set (and defaults to little anyway). There is no other valid ARM sub architecture with ARMv6 or

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-27 Thread Todd Fiala via lldb-dev
Hi Pavel, Will is trying to get this working downstream of here IIRC. Greg, can you have a look and see what you think of the patch? (Also see Pavel's comments). Thanks! -Todd On Wed, Jan 27, 2016 at 1:28 AM, Omair Javaid via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Hi Will, > > I dont u

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-27 Thread Omair Javaid via lldb-dev
Hi Will, I dont understand REPL and thus the benefits it will have by making change to architecture name. I would not recommend to drop any information that we get from the host operating system. LLDB maintains core information alongwith triple in ArchSpec, may be you can parse triple to reflect

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-26 Thread Pavel Labath via lldb-dev
+ Omair I don't really understand arm (sub)-architectures or REPL. The patch seems mostly harmless, but it also feels like a hack to me. A couple of questions: - why does this only pose a problem for REPL? - If I understand correctly, the problem is that someone is looking at the architecture stri

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-25 Thread Hans Wennborg via lldb-dev
This patch looks reasonable to me, but I don't know enough about LLDB to actually review it. +Renato or Pavel maybe? On Thu, Jan 14, 2016 at 11:32 AM, William Dillon via lldb-dev wrote: > Hi again, everyone > > I’d like to ping on this patch now that the 3.8 branch is fairly new, and > merging

Re: [lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-14 Thread William Dillon via lldb-dev
Hi again, everyone I’d like to ping on this patch now that the 3.8 branch is fairly new, and merging it over is fairly straight-forward. Thanks in advance for your comments! - Will > There is a small change that enables correct calculation of arm sub > architectures while using the REPL on a

[lldb-dev] Patch to fix REPL for ARMv7 & ARMv6 on linux

2016-01-06 Thread William Dillon via lldb-dev
Hi All, There is a small change that enables correct calculation of arm sub architectures while using the REPL on arm-linux. As you may of may or may not know, linux appends ‘l’ to arm architecture versions to denote little endian. This sometimes interferes with the determination of the archi