Re: [lldb-dev] Testing through api vs. commands

On Fri, Sep 11, 2015 at 11:42 AM Jim Ingham wrote: > I have held from the beginning that the only tests that should be written > using HandleCommand are those that explicitly test command behavior, and if > it is possible to write a test using the SB API you should always do

Re: [lldb-dev] Testing through api vs. commands

On Thu, Sep 17, 2015 at 10:08 AM wrote: > On Tue, Sep 15, 2015 at 11:36:00PM +, Zachary Turner wrote: > > a) they should be explicitly marked as interface tests. > > What's the decorator for this? > There's not one currently. > > > d) Results of these interface tests

Re: [lldb-dev] Testing through api vs. commands

On Tue, Sep 15, 2015 at 04:46:41PM -0700, Jim Ingham wrote: > > In any case, there's a lot I never could figure out how to do in the SB > > API that I could only do via commands. For example, how do you test > > that a trailing space at the end of the expr --language option's argument > > is

Re: [lldb-dev] Testing through api vs. commands

On Thu, Sep 17, 2015 at 05:20:14PM +, Zachary Turner wrote: > > > a) they should be explicitly marked as interface tests. > > What's the decorator for this? > > There's not one currently. Will there be? > > > d) Results of these interface tests should also not be *verified* by the > > > use

Re: [lldb-dev] Testing through api vs. commands

On Thu, Sep 17, 2015 at 10:39 AM wrote: > On Thu, Sep 17, 2015 at 05:20:14PM +, Zachary Turner wrote: > > > > a) they should be explicitly marked as interface tests. > > > What's the decorator for this? > > > > There's not one currently. > > Will there be? > Whenever someone

Re: [lldb-dev] Testing through api vs. commands

I agree that we should test the command interface, but a) they should be explicitly marked as interface tests. b) There should be MUCH fewer. c) It should only verify that typing a particular command maps to the right core sequence of public / private API calls. Not that the debugger

Re: [lldb-dev] Testing through api vs. commands

> On Sep 15, 2015, at 4:23 PM, d...@burble.org wrote: > > I do still think we need some tests that verify commands run, but I think > those tests should focus not on doing complicated interactions with the > debugger, and instead just verifying that things parse correctly and the

Re: [lldb-dev] Testing through api vs. commands

> On Sep 11, 2015, at 11:47 AM, Zachary Turner wrote: > > We'll probably rewrite tests that we find are failing specifically as a > result of issues like this, but I agree it's not worth re-writing everything > else except on an as-needed basis. > > To make the

Re: [lldb-dev] Testing through api vs. commands

I have held from the beginning that the only tests that should be written using HandleCommand are those that explicitly test command behavior, and if it is possible to write a test using the SB API you should always do it that way for the very reasons you cite. Not everybody agreed with me at