Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Jim Ingham via lldb-dev
> On Sep 12, 2016, at 11:53 AM, Daniel Noland wrote: > > > > On 09/12/2016 11:30 AM, Jim Ingham wrote: >> >>> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: >>> >>> Yes, that was pretty much my assessment when I read through the code. >>> >>> My existing patch (which I will post when I g

Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Daniel Noland via lldb-dev
On 09/12/2016 11:30 AM, Jim Ingham wrote: > >> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: >> >> Yes, that was pretty much my assessment when I read through the code. >> >> My existing patch (which I will post when I get home) takes a very >> conservative approach and only modifies what i

Re: [lldb-dev] Problem with watchpoints

2016-09-12 Thread Jim Ingham via lldb-dev
> On Sep 9, 2016, at 7:33 PM, Daniel Noland wrote: > > Yes, that was pretty much my assessment when I read through the code. > > My existing patch (which I will post when I get home) takes a very > conservative approach and only modifies what is strictly necessary to make > the callback featu

[lldb-dev] Relicensing discussion @ llvm-dev

2016-09-12 Thread Chris Lattner via lldb-dev
Hi LLDB folks, FYI, I kicked off a thread about relicensing on LLVM. It impacts LLDB as well, but it would be great to keep the discussion centralized on one list: http://lists.llvm.org/pipermail/llvm-dev/2016-September/104778.html -Chris ___ lldb-de

Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
On 2016-09-12 16:39, Zachary Turner wrote: Ahh that explains why I didn't notice it. Is the fix straightforward? Sort of. it works if i (locally) do return 0, but that's doesn't seem to be the right thing to do. The common thing to do on Windows is to let the program create a new window (

Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Zachary Turner via lldb-dev
Ahh that explains why I didn't notice it. Is the fix straightforward? On Mon, Sep 12, 2016 at 1:31 AM Carlo Kok via lldb-dev < lldb-dev@lists.llvm.org> wrote: > > > On 2016-09-12 10:06, Carlo Kok via lldb-dev wrote: > > Hi, > > > > ProcessLaunchInfo seems to, unconditionally create a pseudo termin

[lldb-dev] [Bug 24759] The example "Using the lldb.py module in python" is not working on Linux

2016-09-12 Thread via lldb-dev
https://llvm.org/bugs/show_bug.cgi?id=24759 lab...@google.com changed: What|Removed |Added Status|NEW |RESOLVED CC|

Re: [lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
On 2016-09-12 10:06, Carlo Kok via lldb-dev wrote: Hi, ProcessLaunchInfo seems to, unconditionally create a pseudo terminal if there's nothing attached to the stdout/stderr. This seems to end up calling posix_openpt, which is defined as: inline int posix_openpt(int flag) { LLVM_BUILTIN_UNREAC

[lldb-dev] Psuedo terminal on Windows

2016-09-12 Thread Carlo Kok via lldb-dev
Hi, ProcessLaunchInfo seems to, unconditionally create a pseudo terminal if there's nothing attached to the stdout/stderr. This seems to end up calling posix_openpt, which is defined as: inline int posix_openpt(int flag) { LLVM_BUILTIN_UNREACHABLE; } for Windows. This was fine a while ago s