Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-21 Thread Pavel Labath via lldb-dev
On 21/03/2019 13:12, David Chisnall via lldb-dev wrote: On 20 Mar 2019, at 18:23, Arthur O'Dwyer via cfe-dev wrote: Server-side hooks are the answer to this problem. There is no problem. You just use a server-side hook. It is quite unlikely that GitHub will allow LLVM (or any other

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-21 Thread David Chisnall via lldb-dev
On 20 Mar 2019, at 18:23, Arthur O'Dwyer via cfe-dev wrote: > > Server-side hooks are the answer to this problem. There is no problem. You > just use a server-side hook. It is quite unlikely that GitHub will allow LLVM (or any other project) to run arbitrary post-receive hooks. It is far

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-20 Thread Brian Cain via lldb-dev
On Tue, Mar 19, 2019 at 2:00 PM Tom Stellard via cfe-dev < cfe-...@lists.llvm.org> wrote: > Hi, > > I would like to follow up on the previous thread[1], where there was a > consensus > to disallow merge commits in the llvm github repository, and start a > discussion > about how we should enforce

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-20 Thread Tom Stellard via lldb-dev
On 03/20/2019 11:38 AM, Zachary Turner wrote: > It sounds like we need to get someone from the Foundation (chandlerc@, > lattner@, tanya@, someone else?) to reach out to them offline about this. > Yes, we will try to reach out to GitHub directly about this, but I still think we need some kind

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-20 Thread Zachary Turner via lldb-dev
It sounds like we need to get someone from the Foundation (chandlerc@, lattner@, tanya@, someone else?) to reach out to them offline about this. On Wed, Mar 20, 2019 at 11:23 AM Arthur O'Dwyer wrote: > On Wed, Mar 20, 2019 at 2:19 PM Tom Stellard via cfe-dev < > cfe-...@lists.llvm.org> wrote: >

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-20 Thread James Y Knight via lldb-dev
Then we should not accept it. What if someone did the same on a phabricator review? On Wed, Mar 20, 2019 at 2:39 AM Anton Korobeynikov wrote: > > Github PRs are how everyone who is not already super-involved in the > llvm project is going to want to contribute changes, and we ought to be as >

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-20 Thread Anton Korobeynikov via lldb-dev
> Github PRs are how everyone who is not already super-involved in the llvm > project is going to want to contribute changes, and we ought to be as > welcoming as possible to such users. Still we'd need some policy & checks here. Say, what if someone will issue a PR to LLVM 4.0 branch? With

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-19 Thread Eric Christopher via lldb-dev
Honestly I'm looking forward to GitHub's interface here. On Tue, Mar 19, 2019, 1:25 PM James Y Knight via lldb-dev < lldb-dev@lists.llvm.org> wrote: > I think we definitely will want to support github PRs, at the very least > as an _option_, even if we continue running/preferring phabricator. >

Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

2019-03-19 Thread James Y Knight via lldb-dev
I think we definitely will want to support github PRs, at the very least as an _option_, even if we continue running/preferring phabricator. Github PRs are how everyone who is not already super-involved in the llvm project is going to want to contribute changes, and we ought to be as welcoming as