Re: [lldb-dev] Handling callable addresses
Could you suggest any public buildbots where I can test such things for ARM, MIPS and others? > -Original Message- > From: Pavel Labath > Sent: Friday, 22 June, 2018 1:23 PM > To: Tatyana Krasnukha > Cc: Jim Ingham ; LLDB ; Greg > Clayton > Subject: Re: [lldb-dev] Handling callable addresses > > +1 > > While creating the architecture plugin, I noticed that this code could be > moved there, but never got around to doing that. If the code is indeed > equivalent, then we can make a utility function or a common base class that > both plugins can then reuse. > On Thu, 21 Jun 2018 at 23:34, Greg Clayton via lldb-dev d...@lists.llvm.org> wrote: > > > > We now have architecture plug-ins. Target::GetCallableLoadAddress should > defer to the architecture plug-ins and any functionality should be moved into > those plug-ins. There is one for ARM. We will need to make one for MIPS. > > > > > On Jun 21, 2018, at 1:58 PM, Jim Ingham via lldb-dev d...@lists.llvm.org> wrote: > > > > > > It's actually a little lame that we have a switch over architectures in > generic Target code. This should be gotten from the architecture plugin. > GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific > code in Target.cpp, which seems really wrong to me. > > > > > > Not really answering your question except formally none of this code > should be in Target.cpp... > > > > > > Jim > > > > > > > > >> On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev d...@lists.llvm.org> wrote: > > >> > > >> Hi, > > >> > > >> It seems Target::GetCallableLoadAddress does equivalent things for > arm/thumb and for mipses, just written in different forms. May I join these > cases together? > > >> ___ > > >> lldb-dev mailing list > > >> lldb-dev@lists.llvm.org > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_ > > >> cgi-2Dbin_mailman_listinfo_lldb- > 2Ddev&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWq > > >> B0tg&r=yfnu24japkhNGh- > WqJObHXmH3mINtC_2FO828lrNpM0&m=zeb97axU-KzSUy > > >> ceCOnTX3EVhAWc4wKeo1VXIpAS8_A&s=CUWr4NMXX26fzc73yt53_- > B6KZ6mC197fuJ > > >> GVwx08xk&e= > > > > > > ___ > > > lldb-dev mailing list > > > lldb-dev@lists.llvm.org > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_c > > > gi-2Dbin_mailman_listinfo_lldb- > 2Ddev&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0 > > > tg&r=yfnu24japkhNGh- > WqJObHXmH3mINtC_2FO828lrNpM0&m=zeb97axU-KzSUyceC > > > OnTX3EVhAWc4wKeo1VXIpAS8_A&s=CUWr4NMXX26fzc73yt53_- > B6KZ6mC197fuJGVwx > > > 08xk&e= > > > > ___ > > lldb-dev mailing list > > lldb-dev@lists.llvm.org > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi > > -2Dbin_mailman_listinfo_lldb- > 2Ddev&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r > > =yfnu24japkhNGh-WqJObHXmH3mINtC_2FO828lrNpM0&m=zeb97axU- > KzSUyceCOnTX3E > > VhAWc4wKeo1VXIpAS8_A&s=CUWr4NMXX26fzc73yt53_- > B6KZ6mC197fuJGVwx08xk&e= ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] Handling callable addresses
+1 While creating the architecture plugin, I noticed that this code could be moved there, but never got around to doing that. If the code is indeed equivalent, then we can make a utility function or a common base class that both plugins can then reuse. On Thu, 21 Jun 2018 at 23:34, Greg Clayton via lldb-dev wrote: > > We now have architecture plug-ins. Target::GetCallableLoadAddress should > defer to the architecture plug-ins and any functionality should be moved into > those plug-ins. There is one for ARM. We will need to make one for MIPS. > > > On Jun 21, 2018, at 1:58 PM, Jim Ingham via lldb-dev > > wrote: > > > > It's actually a little lame that we have a switch over architectures in > > generic Target code. This should be gotten from the architecture plugin. > > GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific > > code in Target.cpp, which seems really wrong to me. > > > > Not really answering your question except formally none of this code should > > be in Target.cpp... > > > > Jim > > > > > >> On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev > >> wrote: > >> > >> Hi, > >> > >> It seems Target::GetCallableLoadAddress does equivalent things for > >> arm/thumb and for mipses, just written in different forms. May I join > >> these cases together? > >> ___ > >> lldb-dev mailing list > >> lldb-dev@lists.llvm.org > >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > > > ___ > > lldb-dev mailing list > > lldb-dev@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] Handling callable addresses
We now have architecture plug-ins. Target::GetCallableLoadAddress should defer to the architecture plug-ins and any functionality should be moved into those plug-ins. There is one for ARM. We will need to make one for MIPS. > On Jun 21, 2018, at 1:58 PM, Jim Ingham via lldb-dev > wrote: > > It's actually a little lame that we have a switch over architectures in > generic Target code. This should be gotten from the architecture plugin. > GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific > code in Target.cpp, which seems really wrong to me. > > Not really answering your question except formally none of this code should > be in Target.cpp... > > Jim > > >> On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev >> wrote: >> >> Hi, >> >> It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb >> and for mipses, just written in different forms. May I join these cases >> together? >> ___ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] Handling callable addresses
It's actually a little lame that we have a switch over architectures in generic Target code. This should be gotten from the architecture plugin. GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific code in Target.cpp, which seems really wrong to me. Not really answering your question except formally none of this code should be in Target.cpp... Jim > On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev > wrote: > > Hi, > > It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb > and for mipses, just written in different forms. May I join these cases > together? > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
[lldb-dev] Handling callable addresses
Hi, It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb and for mipses, just written in different forms. May I join these cases together? ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
