Re: [lldb-dev] clang-format now supports return type on separate line

Wow, that’s a super handy feature and probably goes a long way toward alleviating concerns about tables. I have to say, I always feel good vibes about a source base when they have lint directives in comments. Shows they run lint as a matter of course. Sean > On Jan 22, 2016, at 12:29 PM,

Re: [lldb-dev] clang-format now supports return type on separate line

Oh neat, I didn't know about that. I'll play around with that when I have some time and see how the behavior works with respect to git clang-format (which formats diffs instead of entire files) On Fri, Jan 22, 2016 at 12:29 PM Pavel Labath wrote: > Apparently, you can also

Re: [lldb-dev] clang-format now supports return type on separate line

Apparently, you can also disable the formatting of a piece of code by a magic comment. Could be quite useful for those tables. From the docs: - Clang-format understands also special comments that switch formatting in a delimited range. The code between a comment // clang-format off or /*

Re: [lldb-dev] clang-format now supports return type on separate line

Okay, thanks for the tip! On Fri, Jan 22, 2016 at 8:32 AM, Zachary Turner wrote: > By the way, one place where you are guaranteed to get undesirable results > is where you have a large array formatted so that the columns line up. > Like in our options tables in the

Re: [lldb-dev] clang-format now supports return type on separate line

Agreed. My guidance has been that we go ahead and require submitters to use clang-format for patches, but to acknowledge that there may be cases where this produces undesirable results. Manual formatting to correct these issues is acceptable and should lead to discussions about concrete

Re: [lldb-dev] clang-format now supports return type on separate line

By the way, one place where you are guaranteed to get undesirable results is where you have a large array formatted so that the columns line up. Like in our options tables in the CommandObjects. If you're using git, one way to avoid having clang-format touch these files is to commit that file by

Re: [lldb-dev] clang-format now supports return type on separate line

Glad to see clang-format getting some improvements. On Thu, Jan 7, 2016 at 10:30 AM, Zachary Turner wrote: > As far as I'm aware, this is the last major incompatibility between LLDB's > style and clang-format's feature set. > > I would appreciate it if more people could

Re: [lldb-dev] clang-format now supports return type on separate line

I tend to agree with Zachary on the overall principle – and I would be willing to clang-format functions when I modify them. I’m concerned about a specific class of functions, though. Let’s say I have a function that has had lots of activity (I’m thinking of, for example, ParseType off in the

Re: [lldb-dev] clang-format now supports return type on separate line

On Thu, Jan 21, 2016 at 11:18 AM Sean Callanan wrote: > I tend to agree with Zachary on the overall principle – and I would be > willing to clang-format functions when I modify them. I’m concerned about > a specific class of functions, though. Let’s say I have a function

[lldb-dev] clang-format now supports return type on separate line

As far as I'm aware, this is the last major incompatibility between LLDB's style and clang-format's feature set. I would appreciate it if more people could try it out with a few of their patches, and let me know if any LLDB style incompatibilities arise in the formatted code. I would eventually