Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
moved to https://reviews.llvm.org/D44321 it would've saved time if instructions had a TLDR that showed: ``` brew install homebrew/php/arcanist arc diff master # and following instructions ``` On Fri, Mar 9, 2018 at 8:44 AM, Ted Woodward via lldb-dev wrote: > Also see http://llvm.org/docs/Contributing.html > > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a > Linux Foundation Collaborative Project > >> -Original Message- >> From: lldb-dev [mailto:lldb-dev-boun...@lists.llvm.org] On Behalf Of Davide >> Italiano via lldb-dev >> Sent: Friday, March 09, 2018 10:27 AM >> To: Timothee Cour >> Cc: LLDB >> Subject: Re: [lldb-dev] how do i submit my patch for 'Support demangling for >> D >> symbols via dlopen' >> >> On Fri, Mar 9, 2018 at 12:44 AM, Timothee Cour via lldb-dev > d...@lists.llvm.org> wrote: >> > I've registered to >> > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits and sent >> > my patch via that email to lldb-comm...@lists.llvm.org but doesn't >> > appear yet on http://lists.llvm.org/pipermail/lldb-commits/ ; how long >> > does it take for >> > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits to >> > subscribe? >> > >> >> Again, please sign-up for Phabricator as pointed out on the previous mail and >> submit the patch there https://llvm.org/docs/Phabricator.html >> >> > Still not sure why github PR's can't be accepted to remove all this >> > friction for outside developpers. >> > >> >> Because llvm main repo is still on svn. Once the migration to GitHub will >> happen, probably PR will be accepted at some point. >> >> Thanks, >> >> -- >> Davide >> ___ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
Also see http://llvm.org/docs/Contributing.html -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project > -Original Message- > From: lldb-dev [mailto:lldb-dev-boun...@lists.llvm.org] On Behalf Of Davide > Italiano via lldb-dev > Sent: Friday, March 09, 2018 10:27 AM > To: Timothee Cour > Cc: LLDB > Subject: Re: [lldb-dev] how do i submit my patch for 'Support demangling for D > symbols via dlopen' > > On Fri, Mar 9, 2018 at 12:44 AM, Timothee Cour via lldb-dev d...@lists.llvm.org> wrote: > > I've registered to > > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits and sent > > my patch via that email to lldb-comm...@lists.llvm.org but doesn't > > appear yet on http://lists.llvm.org/pipermail/lldb-commits/ ; how long > > does it take for > > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits to > > subscribe? > > > > Again, please sign-up for Phabricator as pointed out on the previous mail and > submit the patch there https://llvm.org/docs/Phabricator.html > > > Still not sure why github PR's can't be accepted to remove all this > > friction for outside developpers. > > > > Because llvm main repo is still on svn. Once the migration to GitHub will > happen, probably PR will be accepted at some point. > > Thanks, > > -- > Davide > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
On Fri, Mar 9, 2018 at 12:44 AM, Timothee Cour via lldb-dev wrote: > I've registered to > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits and sent > my patch via that email to lldb-comm...@lists.llvm.org but doesn't > appear yet on http://lists.llvm.org/pipermail/lldb-commits/ ; how long > does it take for > http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits to > subscribe? > Again, please sign-up for Phabricator as pointed out on the previous mail and submit the patch there https://llvm.org/docs/Phabricator.html > Still not sure why github PR's can't be accepted to remove all this > friction for outside developpers. > Because llvm main repo is still on svn. Once the migration to GitHub will happen, probably PR will be accepted at some point. Thanks, -- Davide ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
I've registered to http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits and sent my patch via that email to lldb-comm...@lists.llvm.org but doesn't appear yet on http://lists.llvm.org/pipermail/lldb-commits/ ; how long does it take for http://lists.llvm.org/cgi-bin/mailman/subscribe/lldb-commits to subscribe? Still not sure why github PR's can't be accepted to remove all this friction for outside developpers. On Tue, Feb 27, 2018 at 9:25 AM, Jim Ingham wrote: > I only briefly scanned the patch, but I'm not sure treating D as another > mangling variant of C++ is the best model - I think it will be easier if we > gather all the separate language features up in the individual languages. > You might have a look at the swift-enabled lldb > (https://github.com/apple/swift-lldb/) to see how it is handled there. > That's a little weak because we iterate over supported languages by hand. > When there were a few that wasn't an issue, but as we pick up more languages, > we should introduce a "do over supported languages" feature which would clean > up the logic there. > > Jim > > >> On Feb 26, 2018, at 9:01 PM, Timothee Cour via lldb-dev >> wrote: >> >> https://github.com/llvm-mirror/lldb/pull/3 >> >> it would be *really* nice if llvm or lldb accepted industry standard >> github PR's, at least as an option. Would make contributing so much >> easier for outsiders >> ___ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
I only briefly scanned the patch, but I'm not sure treating D as another mangling variant of C++ is the best model - I think it will be easier if we gather all the separate language features up in the individual languages. You might have a look at the swift-enabled lldb (https://github.com/apple/swift-lldb/) to see how it is handled there. That's a little weak because we iterate over supported languages by hand. When there were a few that wasn't an issue, but as we pick up more languages, we should introduce a "do over supported languages" feature which would clean up the logic there. Jim > On Feb 26, 2018, at 9:01 PM, Timothee Cour via lldb-dev > wrote: > > https://github.com/llvm-mirror/lldb/pull/3 > > it would be *really* nice if llvm or lldb accepted industry standard > github PR's, at least as an option. Would make contributing so much > easier for outsiders > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
On Mon, Feb 26, 2018 at 9:01 PM, Timothee Cour via lldb-dev wrote: > https://github.com/llvm-mirror/lldb/pull/3 > > it would be *really* nice if llvm or lldb accepted industry standard > github PR's, at least as an option. Would make contributing so much > easier for outsiders See the other thread as well. https://llvm.org/docs/Phabricator.html Thanks, -- Davide ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
[lldb-dev] how do i submit my patch for 'Support demangling for D symbols via dlopen'
https://github.com/llvm-mirror/lldb/pull/3 it would be *really* nice if llvm or lldb accepted industry standard github PR's, at least as an option. Would make contributing so much easier for outsiders ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
