Re: [lldb-dev] r329889 - Use in-tree dsymutil on Darwin

[Jonas Devlieghere via lldb-dev]

Hi Ted,

I tried to reproduce this issue over the weekend on a Linux machine, but to no 
success. 

> On Apr 20, 2018, at 4:46 PM, Ted Woodward via lldb-dev 
>  wrote:
> 
> r329889 says "Use in-tree dsymutil on Darwin", but it's got these change in
> test/CMakeLists.txt:
> -set(LLDB_TEST_DEPS lldb)
> +set(LLDB_TEST_DEPS lldb dsymutil)
> 
> ...
> 
> +  --dsymutil $
> 
> 
> These changes aren't gated by a check for Darwin, so they happen on all
> systems. On my machine (Ubuntu 14), which doesn't have dsymutil, cmake
> generation gives errors about missing dependency dsymutil.

As dsymutil is an LLVM target, it should be available regardless of the host 
machine. That is, as Pavel noted, unless you’re doing a standalone build. Any 
chance this is the case? 

> CMake Error at tools/lldb/test/CMakeLists.txt:161 (add_dependencies):
>   The dependency target "dsymutil" of target "lldb-dotest" does not exist.
> 
> Jonas, can you gate those changes with a check for Darwin, which is the
> intention of the patch?

I’ve changed the configuration to only add the dependency when not doing a 
stand-alone built in r330568. Please let me know if that works for you. 

> 
> Ted
> 
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project
> 
> 
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

...

> On Apr 23, 2018, at 9:32 AM, Pavel Labath via lldb-dev 
>  wrote:
> 
> On Fri, 20 Apr 2018 at 16:46, Ted Woodward via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
> 
>> r329889 says "Use in-tree dsymutil on Darwin", but it's got these change
> in
>> test/CMakeLists.txt:
>> -set(LLDB_TEST_DEPS lldb)
>> +set(LLDB_TEST_DEPS lldb dsymutil)
> 
> Shouldn't this just be llvm-dsymutil, which should be always present
> (except standalone builds, I guess)?

I renamed llvm-dsymutil to just dsymutil a while ago because we’ve upstreamed 
almost everything (only support for BCSymbolMaps is missing, which I’m in the 
progress of upstreaming). 

> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] r329889 - Use in-tree dsymutil on Darwin

[Pavel Labath via lldb-dev]

On Fri, 20 Apr 2018 at 16:46, Ted Woodward via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> r329889 says "Use in-tree dsymutil on Darwin", but it's got these change
in
> test/CMakeLists.txt:
> -set(LLDB_TEST_DEPS lldb)
> +set(LLDB_TEST_DEPS lldb dsymutil)

Shouldn't this just be llvm-dsymutil, which should be always present
(except standalone builds, I guess)?
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

[lldb-dev] r329889 - Use in-tree dsymutil on Darwin

[Ted Woodward via lldb-dev]

r329889 says "Use in-tree dsymutil on Darwin", but it's got these change in
test/CMakeLists.txt:
-set(LLDB_TEST_DEPS lldb)
+set(LLDB_TEST_DEPS lldb dsymutil)

...

+  --dsymutil $


These changes aren't gated by a check for Darwin, so they happen on all
systems. On my machine (Ubuntu 14), which doesn't have dsymutil, cmake
generation gives errors about missing dependency dsymutil.

CMake Error at tools/lldb/test/CMakeLists.txt:161 (add_dependencies):
   The dependency target "dsymutil" of target "lldb-dotest" does not exist.

Jonas, can you gate those changes with a check for Darwin, which is the
intention of the patch?

Ted

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project


___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev