Re: [lldb-dev] [cfe-dev] [Release-testers] [9.0.0 Release] Release Candidate 2 is here

2019-08-20 Thread Hans Wennborg via lldb-dev
On Sun, Aug 18, 2019 at 6:42 AM Marshall Clow wrote: > > > > On Fri, Aug 16, 2019 at 2:23 AM Sylvestre Ledru via cfe-dev > wrote: >> One severe regression on Debian on libc++ on mips* >> https://bugs.llvm.org/show_bug.cgi?id=43011 >> >> Simon found the regressor! >> >> Besides that, we look

Re: [lldb-dev] [Release-testers] [9.0.0 Release] Release Candidate 2 is here

2019-08-20 Thread Hans Wennborg via lldb-dev
Hi Bernhard, On Sat, Aug 17, 2019 at 4:30 PM Bernhard Rosenkraenzer wrote: > The only serious issue we've run into so far is that clang crashes when > trying to build current firefox on x86_64. Will put up a bug report later. Did you get a chance to file that bug report yet? Thanks, Hans

Re: [lldb-dev] [Release-testers] [9.0.0 Release] Release Candidate 2 is here

2019-08-20 Thread Hans Wennborg via lldb-dev
No, there should be no mismatch now. Maybe you ended up using a version of test-release.sh that doen't have the fixes? On Sun, Aug 18, 2019 at 6:47 PM Brian Cain wrote: > > When I built rv2 for SLES11 linux I saw the same phase 2/3 mismatch. Is that > expected? > > On Wed, Aug 14, 2019, 3:15

Re: [lldb-dev] [RFC] Fast Conditional Breakpoints (FCB)

2019-08-20 Thread Tamas Berghammer via lldb-dev
It is great that you are looking at supporting these fast breakpoints but I am concerned about the instruction moving code along the same lines Pavel mentioned. Copying instructions from 1 location to another is fairly complicated even without considering the issue of jump targets and jump target

Re: [lldb-dev] [RFC] Fast Conditional Breakpoints (FCB)

2019-08-20 Thread Pavel Labath via lldb-dev
On 20/08/2019 00:11, Ismail Bennani wrote: On Aug 19, 2019, at 2:30 PM, Frédéric Riss wrote: On Aug 16, 2019, at 11:13 AM, Ismail Bennani via lldb-dev wrote: Hi Pavel, Thanks for all your feedbacks. I’ve been following the discussion closely and find your approach quite interesting.

Re: [lldb-dev] [Bug 22232] Conditional breakpoint test skipped for Windows

2019-08-20 Thread Ismail Bennani via lldb-dev
Thanks! I’ll remove these annotations from the test and submit a patch. Ismail > On Aug 20, 2019, at 2:11 PM, Stella Stamenova wrote: > > It looks like the tests are indeed passing on Windows. > > Thanks, > -Stella > > -Original Message- > From: lldb-dev On Behalf Of Ismail

Re: [lldb-dev] [RFC] Fast Conditional Breakpoints (FCB)

2019-08-20 Thread Jim Ingham via lldb-dev
> On Aug 20, 2019, at 3:30 AM, Tamas Berghammer via lldb-dev > wrote: > > It is great that you are looking at supporting these fast breakpoints > but I am concerned about the instruction moving code along the same > lines Pavel mentioned. Copying instructions from 1 location to another > is

[lldb-dev] [Bug 22232] Conditional breakpoint test skipped for Windows

2019-08-20 Thread Ismail Bennani via lldb-dev
Hi, While looking at the LLDB test suite, I noticed that the test for conditional breakpoints (TestBreakpointConditions.py) is skipped on Windows. The test has an annotation `skipIfWindows` with a comment: `# Requires EE to support COFF on Windows (http://llvm.org/pr22232)` This bug was

Re: [lldb-dev] [Release-testers] [9.0.0 Release] Release Candidate 2 is here

2019-08-20 Thread Brian Cain via lldb-dev
Oh! Indeed, that was probably it. I'll try again. On Tue, Aug 20, 2019, 5:26 AM Hans Wennborg wrote: > No, there should be no mismatch now. Maybe you ended up using a > version of test-release.sh that doen't have the fixes? > > On Sun, Aug 18, 2019 at 6:47 PM Brian Cain wrote: > > > > When I