Re: [lldb-dev] Object identities in the LLDB's C++ API

2019-02-07 Thread Pavel Labath via lldb-dev
On 06/02/2019 23:11, Joshua Peraza via lldb-dev wrote: Adding a hashes where we need them SGTM. I think that's a reasonable approach. We can decide on the best hash and equality functions on a case-by-case basis. ___ lldb-dev mailing list

Re: [lldb-dev] Object identities in the LLDB's C++ API

2019-02-06 Thread Greg Clayton via lldb-dev
> On Feb 6, 2019, at 2:11 PM, Joshua Peraza wrote: > > Adding a hashes where we need them SGTM. > > On Mon, Feb 4, 2019 at 10:31 AM Greg Clayton > wrote: > If it is inside the object itself, and we have only 1 user data "void *" per > object, I can see many

Re: [lldb-dev] Object identities in the LLDB's C++ API

2019-02-06 Thread Joshua Peraza via lldb-dev
Adding a hashes where we need them SGTM. On Mon, Feb 4, 2019 at 10:31 AM Greg Clayton wrote: > If it is inside the object itself, and we have only 1 user data "void *" > per object, I can see many clients wanting to use this user data. > This surprised me though. There are situations where

Re: [lldb-dev] Object identities in the LLDB's C++ API

2019-02-04 Thread Greg Clayton via lldb-dev
It would be easy to add the equality or comparison and other operators to any items that don't have them. I am not a fan of adding user data. It can't live be in the SBXXX object itself, because we can't change the member variables in the objects for API backward compat issues. If it is inside

Re: [lldb-dev] Object identities in the LLDB's C++ API

2019-01-29 Thread Leonard Mosescu via lldb-dev
Reviving this old thread and +Joshua Peraza who's also interested in this. On Wed, Dec 13, 2017 at 4:17 PM Leonard Mosescu wrote: > Thanks Greg, > > 1. Expose the opaque ptr as an opaque handle() > - this is an easy, quick and convenient solution for many SBxxx types > but it may not

Re: [lldb-dev] Object identities in the LLDB's C++ API

2017-12-13 Thread Leonard Mosescu via lldb-dev
Thanks Greg, 1. Expose the opaque ptr as an opaque handle() - this is an easy, quick and convenient solution for many SBxxx types but it may not work for all That would be nice, but that won't always work with how LLDB is currently > coded for SBFrame and possibly SBThread. These objects

Re: [lldb-dev] Object identities in the LLDB's C++ API

2017-12-13 Thread Greg Clayton via lldb-dev
> On Dec 13, 2017, at 11:44 AM, Leonard Mosescu via lldb-dev > wrote: > > LLDB's C++ API deals with SBxxx objects, most of which are PIMPL-style > wrappers around an opaque pointer to the internal implementation. These SBxxx > objects act as handles and are