mydeveloperday wrote:
> @mydeveloperday What do you think about merging this PR to the release branch?
I'm ok if you are happy with it..
https://github.com/llvm/llvm-project/pull/87735
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llv
https://github.com/mydeveloperday approved this pull request.
Looks good,
https://github.com/llvm/llvm-project/pull/87735
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/86609
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/86609
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -4756,8 +4757,10 @@ void Verifier::visitProfMetadata(Instruction &I, MDNode
*MD) {
// Check consistency of !prof branch_weights metadata.
if (ProfName.equals("branch_weights")) {
+unsigned int Offset = getBranchWeightOffset(I);
if (isa(&I)) {
- Check(MD->
@@ -55,6 +55,20 @@ MDNode *getBranchWeightMDNode(const Instruction &I);
/// Nullptr otherwise.
MDNode *getValidBranchWeightMDNode(const Instruction &I);
+/// Check if Branch Weight Metadata has an "expected" field from an
llvm.expect*
+/// intrinsic
+bool hasExpectedProvenanc
@@ -55,6 +55,20 @@ MDNode *getBranchWeightMDNode(const Instruction &I);
/// Nullptr otherwise.
MDNode *getValidBranchWeightMDNode(const Instruction &I);
+/// Check if Branch Weight Metadata has an "expected" field from an
llvm.expect*
+/// intrinsic
+bool hasExpectedProvenanc
@@ -1210,12 +1210,22 @@ Instruction *Instruction::cloneImpl() const {
void Instruction::swapProfMetadata() {
MDNode *ProfileData = getBranchWeightMDNode(*this);
- if (!ProfileData || ProfileData->getNumOperands() != 3)
+ if (!isBranchWeightMD(ProfileData))
return;
-
@@ -1210,12 +1210,22 @@ Instruction *Instruction::cloneImpl() const {
void Instruction::swapProfMetadata() {
MDNode *ProfileData = getBranchWeightMDNode(*this);
- if (!ProfileData || ProfileData->getNumOperands() != 3)
+ if (!isBranchWeightMD(ProfileData))
return;
-
@@ -5196,7 +5198,11 @@ void SwitchInstProfUpdateWrapper::init() {
if (!ProfileData)
return;
- if (ProfileData->getNumOperands() != SI.getNumSuccessors() + 1) {
+ // FIXME: This check belongs in ProfDataUtils. Its almost equivalent to
+ // getValidBranchWeightMDNode(),
@@ -106,6 +104,30 @@ bool hasValidBranchWeightMD(const Instruction &I) {
return getValidBranchWeightMDNode(I);
}
+bool hasExpectedProvenance(const Instruction &I) {
+ auto *ProfileData = I.getMetadata(LLVMContext::MD_prof);
+ return hasExpectedProvenance(ProfileData);
+}
+
@@ -55,6 +55,20 @@ MDNode *getBranchWeightMDNode(const Instruction &I);
/// Nullptr otherwise.
MDNode *getValidBranchWeightMDNode(const Instruction &I);
+/// Check if Branch Weight Metadata has an "expected" field from an
llvm.expect*
+/// intrinsic
+bool hasExpectedProvenanc
https://github.com/MatzeB commented:
I guess this is deliberately designed around a `bool IsExpected` rather than a
more generic API. I guess I'm fine with it given the current patch, though I
would bet it's just a question of time for someone to add more sources now...
(so gotta make sure to
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/86609
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arichardson wrote:
@mstorsjo It would be great if you could test this on windows.
https://github.com/llvm/llvm-project/pull/88075
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Alexander Richardson (arichardson)
Changes
Currently, the testsuite uses the default runtimes path to find the
runtimes libraries which may or may not match the just-built runtimes.
This change uses the `-resource-dir` flag
https://github.com/arichardson created
https://github.com/llvm/llvm-project/pull/88075
Currently, the testsuite uses the default runtimes path to find the
runtimes libraries which may or may not match the just-built runtimes.
This change uses the `-resource-dir` flag for clang whenever
`COMPILER
https://github.com/dpaoliello milestoned
https://github.com/llvm/llvm-project/pull/88016
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/maksfb commented:
Is information we emit in the symbol table insufficient to establish the
fragment relationship?
https://github.com/llvm/llvm-project/pull/87968
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.or
https://github.com/maksfb commented:
Let's make `hasCFI()` return true for injected functions.
https://github.com/llvm/llvm-project/pull/87967
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/cjacek approved this pull request.
https://github.com/llvm/llvm-project/pull/88016
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
efriedma-quic wrote:
LGTM. (This only affects Arm64EC, so it's very safe to backport.)
https://github.com/llvm/llvm-project/pull/88016
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/minglotus-6 created
https://github.com/llvm/llvm-project/pull/88024
This is still working in progress. Need to update all callers of
'ComputeImportForModule' properly
>From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001
From: mingmingl
Date: Thu, 4 Apr 20
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Daniel Paoliello (dpaoliello)
Changes
Backports #87542 to v18
While attempting to build some Rust code, I was getting linker errors due to
missing functions that are implemented in `compiler-rt`. Turns out that when
`compiler-r
https://github.com/dpaoliello created
https://github.com/llvm/llvm-project/pull/88016
Backports #87542 to v18
While attempting to build some Rust code, I was getting linker errors due to
missing functions that are implemented in `compiler-rt`. Turns out that when
`compiler-rt` is built for Ar
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/87980
>From 183ab14683a335e65891e1d585f69231699efceb Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Mon, 8 Apr 2024 11:25:29 +
Subject: [PATCH] [mlir][Interfaces][WIP] `ValueBoundsOpInterface`: `V
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/87976
>From d8c3fd63044c9b7dfd33c2023729b9a4b72b4886 Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Mon, 8 Apr 2024 09:44:02 +
Subject: [PATCH] [mlir][Interfaces] `ValueBoundsOpInterface`: Fix typ
AtariDreams wrote:
> LGTM
I don't have commit access by the way.
https://github.com/llvm/llvm-project/pull/86153
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi
@@ -75,6 +75,75 @@ struct MulIOpInterface
}
};
+struct SelectOpInterface
matthias-springer wrote:
`SelectOpInterface` was already merged. I have to rebase.
https://github.com/llvm/llvm-project/pull/87980
___
llv
llvmbot wrote:
@llvm/pr-subscribers-mlir-scf
Author: Matthias Springer (matthias-springer)
Changes
This commit generalizes and cleans up the `ValueBoundsConstraintSet` API. The
API used to provide function overloads for comparing/computing bounds of:
- index-typed SSA value
- dimension of
llvmbot wrote:
@llvm/pr-subscribers-mlir-memref
@llvm/pr-subscribers-mlir-linalg
Author: Matthias Springer (matthias-springer)
Changes
This commit generalizes and cleans up the `ValueBoundsConstraintSet` API. The
API used to provide function overloads for comparing/computing bounds of:
-
llvmbot wrote:
@llvm/pr-subscribers-mlir-tensor
Author: Matthias Springer (matthias-springer)
Changes
This commit generalizes and cleans up the `ValueBoundsConstraintSet` API. The
API used to provide function overloads for comparing/computing bounds of:
- index-typed SSA value
- dimension
https://github.com/matthias-springer created
https://github.com/llvm/llvm-project/pull/87980
This commit generalizes and cleans up the `ValueBoundsConstraintSet` API. The
API used to provide function overloads for comparing/computing bounds of:
- index-typed SSA value
- dimension of shaped valu
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/87976
>From 4a019ca348ce2a65684e6417b656a51437e8176d Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Mon, 8 Apr 2024 09:44:02 +
Subject: [PATCH] [mlir][Interfaces] `ValueBoundsOpInterface`: Fix typ
matthias-springer wrote:
It is currently not possible to trigger this bug. New columns are always added
to the constraint set as symbols. Only the first added SSA value (for which we
compute a bound) is added as a dimension. There is currently no API to compute
a bounds for an "AffineMap + ope
joker-eph wrote:
Can you provide a test that exercises this? Thanks!
https://github.com/llvm/llvm-project/pull/87976
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com
https://github.com/MacDue approved this pull request.
https://github.com/llvm/llvm-project/pull/87976
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Matthias Springer (matthias-springer)
Changes
This was likely a copy-and-paste typo.
---
Full diff: https://github.com/llvm/llvm-project/pull/87976.diff
1 Files Affected:
- (modified) mlir/lib/Interfaces/ValueBoundsOpInterface.cpp (+1-1)
https://github.com/matthias-springer created
https://github.com/llvm/llvm-project/pull/87976
This was likely a copy-and-paste typo.
>From a09cbb284df8419e6ce819e289aa88bf86b66842 Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Mon, 8 Apr 2024 09:44:02 +
Subject: [PATCH] [mlir][Inter
ilya-biryukov wrote:
Thanks for fixing it quickly, we'll try the new patch and get back with the
results.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/dcci requested changes to this pull request.
Can you add a test? that way we can better understand what this function
actually does, given it touches a core functionality.
https://github.com/llvm/llvm-project/pull/87967
___
llvm-bra
https://github.com/nikic milestoned
https://github.com/llvm/llvm-project/pull/86697
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/nikic milestoned
https://github.com/llvm/llvm-project/pull/86698
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/nikic milestoned
https://github.com/llvm/llvm-project/pull/86728
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/nikic milestoned
https://github.com/llvm/llvm-project/pull/86731
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/86153
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov converted_to_draft
https://github.com/llvm/llvm-project/pull/87967
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/87968
BAT contains metadata about fragment relationships. Use it directly
before name-based matching. This removes warnings about control flow
between unrelated fragments.
Test Plan: TBD
_
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/87967
This fixes an issue where `PatchEntries` overwrites function body but
keeps CFI untouched. Existing FDEs thus become invalid. This doesn't
affect unwinding because patched functions are transparent from
EH/unwindin
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/87743
>From 251020f10d1e6a7a888164748f78acc6994e0ab3 Mon Sep 17 00:00:00 2001
From: Amir Ayupov
Date: Fri, 5 Apr 2024 07:36:40 -0700
Subject: [PATCH] Remove stats logging
Created using spr 1.3.4
---
bolt/lib/Profile/D
50 matches
Mail list logo
